Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure WGPU buffers are created with initial data if available #93

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Make sure WGPU buffers are created with initial data if available #93

merged 2 commits into from
Nov 1, 2024

Conversation

aleino-nv
Copy link
Contributor

No description provided.

@aleino-nv
Ensure that SimpleShaderObjectData returns nullptr for empty buffer
9d292cb 
This is a C++ technicality, and is not known to have caused any issue.

https://en.cppreference.com/w/cpp/container/vector/data says:
"If size() is ​0​, data() may or may not return a null pointer."

Thus, we check if the underlying std::vector is empty and then explicitly return nullptr
in this case.
@skallweitNV skallweitNV merged commit 93c2ba8 into shader-slang:main Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skallweitNV skallweitNV skallweitNV left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleino-nv @skallweitNV