Propagate wsgl compilation errors #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgpuDeviceCreateShaderModule reports errors via a callback. Previously, the callback only printed the error, but now, the error can be read back and used to report SLANG_FAIL from createShaderModule. Work on Issue 5291
cheneym2
merged commit 7d12a41
into
shader-slang:cheneym2/wgpu_propagate_error
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wgpuDeviceCreateShaderModule reports
errors via a callback. Previously, the callback
only printed the error, but now, the error
can be read back and used to report SLANG_FAIL from createShaderModule.
Work on Issue 5291