Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End to end SPIR-V precompiled target module unit test #5435

Closed
cheneym2 opened this issue Oct 29, 2024 · 1 comment
Closed

End to end SPIR-V precompiled target module unit test #5435

cheneym2 opened this issue Oct 29, 2024 · 1 comment
Assignees
@cheneym2
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Milestone
Q1 2025 (Winter)

Comments

@cheneym2
Copy link
Collaborator

We need a test for the full PrecompileService_Experimental interface as a unit test, using SPIR-V.
This requires having spirv-link access in Slang.
@cheneym2 cheneym2 self-assigned this Oct 29, 2024
@cheneym2 cheneym2 added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Oct 29, 2024
@cheneym2 cheneym2 added this to the Q4 2024 (Fall) milestone Oct 29, 2024
@cheneym2
Copy link
Collaborator Author

#6236 fixes this issue also

cheneym2 added a commit to cheneym2/slang that referenced this issue Feb 3, 2025
@cheneym2
Fix precompiledTargetModule tests
4753535 
In the SPIR-V backend of Slang, compiling a shader
that contains some modules with precompiled target
blobs will produce only a "glue" SPIR-V output which
needs to be linked with the assorted precompiled
blobs to be complete.

Closes shader-slang#5435
Closes shader-slang#6170
@cheneym2 cheneym2 closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheneym2 cheneym2

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
Q1 2025 (Winter)
Development

No branches or pull requests
1 participant
@cheneym2