Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F dont load description at lower level #660

Open
wants to merge 3 commits into
base: noetic-devel
Choose a base branch
from

Conversation

mikramarc
Copy link
Contributor

@mikramarc mikramarc commented Jul 15, 2021

Proposed changes

Preventing loading of robot description at low level by default, while maintaining the option in the low level launchfile. This is step one of this epic:

https://shadowrobot.atlassian.net/wiki/spaces/SDSR/pages/2645065729/Autodetection+integration+plan

Checklist

If the task is applicable to this pull request (see applicability criteria in brackets), make sure it is completed before checking the corresponding box. Otherwise, tick the box right away. Make sure that ALL boxes are checked BEFORE the PR is merged.

  • Manually tested that added code works as intended (if any functional/runnable code is added).
  • Added automated tests (if a new class is added (Python or C++), interface of that class must be unit tested).
  • Tested on real hardware (if the changed or added code is used with the real hardware).
  • Added documentation (For any new feature, explain what it does and how to use it. Write the documentation in a relevant space, e.g. Github, Confluence, etc.)

@mikramarc mikramarc requested review from a team as code owners July 15, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant