feat(local): Support SIP008 online configuration #1123
clippy ubuntu-latest
8 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 8 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.80.0-nightly (78a775127 2024-05-11)
- cargo 1.80.0-nightly (4de0094ac 2024-05-09)
- clippy 0.1.80 (78a7751 2024-05-11)
Annotations
Check warning on line 1199 in src/service/local.rs
github-actions / clippy ubuntu-latest
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/service/local.rs:1199:27
|
1199 | ConfigDisplay(&self),
| ^^^^^ help: change this to: `self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 1173 in src/service/local.rs
github-actions / clippy ubuntu-latest
value assigned to `is_first` is never read
warning: value assigned to `is_first` is never read
--> src/service/local.rs:1173:21
|
1173 | is_first = false;
| ^^^^^^^^
|
= help: maybe it is overwritten before being read?
= note: `#[warn(unused_assignments)]` on by default
Check warning on line 1169 in src/service/local.rs
github-actions / clippy ubuntu-latest
variable `is_first` is assigned to, but never used
warning: variable `is_first` is assigned to, but never used
--> src/service/local.rs:1169:25
|
1169 | let mut is_first = true;
| ^^^^^^^^
|
= note: consider using `_is_first` instead
= note: `#[warn(unused_variables)]` on by default
Check warning on line 1246 in src/service/local.rs
github-actions / clippy ubuntu-latest
variable does not need to be mutable
warning: variable does not need to be mutable
--> src/service/local.rs:1246:17
|
1246 | let mut has_things_to_do = arc_self.config_path.is_some();
| ----^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Check warning on line 201 in crates/shadowsocks-service/src/local/tun/mod.rs
github-actions / clippy ubuntu-latest
this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
warning: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false
--> crates/shadowsocks-service/src/local/tun/mod.rs:201:24
|
201 | if n <= IFF_PI_PREFIX_LEN {
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: because `IFF_PI_PREFIX_LEN` is the minimum value for this type, the case where the two sides are not equal never occurs, consider using `n == IFF_PI_PREFIX_LEN` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
= note: requested on the command line with `-W clippy::absurd-extreme-comparisons`
Check warning on line 172 in crates/shadowsocks-service/src/local/tun/tcp.rs
github-actions / clippy ubuntu-latest
transmute used without annotations
warning: transmute used without annotations
--> crates/shadowsocks-service/src/local/tun/tcp.rs:172:38
|
172 | let recv_buf = unsafe { mem::transmute::<_, &mut [u8]>(buf.unfilled_mut()) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider adding missing annotations: `transmute::<&mut [std::mem::MaybeUninit<u8>], &mut [u8]>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
= note: `#[warn(clippy::missing_transmute_annotations)]` on by default
Check warning on line 197 in crates/shadowsocks-service/src/local/fake_dns/manager.rs
github-actions / clippy ubuntu-latest
field assignment outside of initializer for an instance created with Default::default()
warning: field assignment outside of initializer for an instance created with Default::default()
--> crates/shadowsocks-service/src/local/fake_dns/manager.rs:197:13
|
197 | c.ipv4_network = ipv4_network_str;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: consider initializing the variable with `local::fake_dns::proto::StorageMeta { ipv4_network: ipv4_network_str, ipv6_network: ipv6_network_str, version: FAKE_DNS_MANAGER_STORAGE_VERSION }` and removing relevant reassignments
--> crates/shadowsocks-service/src/local/fake_dns/manager.rs:196:13
|
196 | let mut c = proto::StorageMeta::default();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
= note: `#[warn(clippy::field_reassign_with_default)]` on by default
Check warning on line 167 in crates/shadowsocks-service/src/local/fake_dns/manager.rs
github-actions / clippy ubuntu-latest
this operation has no effect
warning: this operation has no effect
--> crates/shadowsocks-service/src/local/fake_dns/manager.rs:167:34
|
167 | .flush_every_ms(Some(1 * 1000))
| ^^^^^^^^ help: consider reducing it to: `1000`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
= note: `#[warn(clippy::identity_op)]` on by default