Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added testing for the exit handlers #64

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

1p22geo
Copy link
Contributor

@1p22geo 1p22geo commented Sep 16, 2024

I know.

It's not perfect.

It's far from perfect.

But this feature should be testable too.

Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: 20e5f81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@1p22geo 1p22geo marked this pull request as draft September 16, 2024 09:51
@1p22geo
Copy link
Contributor Author

1p22geo commented Sep 17, 2024

ahhhh the lockfile

@1p22geo
Copy link
Contributor Author

1p22geo commented Sep 17, 2024

wdym lockfile missing
it was there at f5c4af3

the CI at that commit says ERR_PNPM_NO_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is absent
https://github.com/shahradelahi/storage-box/actions/runs/10881607810/job/30216477688

but the file is there
https://github.com/shahradelahi/storage-box/blob/f5c4af3608a41b5d15a123dd5fa5beff168a6a08/pnpm-lock.yaml

what is going on
is this PR cursed

@1p22geo
Copy link
Contributor Author

1p22geo commented Sep 17, 2024

image
Works on my machine.

@shahradelahi
Copy link
Owner

It's because you're using a different pnpm version. Use corepack enable; it automatically downloads and uses the package manager specified in package.json.

@1p22geo
Copy link
Contributor Author

1p22geo commented Sep 18, 2024

image

@1p22geo
Copy link
Contributor Author

1p22geo commented Sep 18, 2024

alr how about now

@shahradelahi shahradelahi marked this pull request as ready for review September 19, 2024 21:35
package.json Outdated
@@ -51,6 +51,7 @@
"dependencies": {
"@msgpack/msgpack": "3.0.0-beta2",
"debounce": "^2.1.0",
"sinon": "^19.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing modules should be installed as devDependencies

@shahradelahi shahradelahi merged commit c982585 into shahradelahi:canary Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants