@langalex in order to validate with a new Rails 8 project, I want to:
gem "comfortable_media_surfer", git: "https://github.com/cobot/comfortable-media-surfer", branch: "fix-redactor"
but then bundle fails with /bin/sh: esbuild: command not found

@avonderluft yep, see #8 (comment)

I can add a Rake task tomorrow

@langalex in order to validate with a new Rails 8 project, I want to: gem "comfortable_media_surfer", git: "https://github.com/cobot/comfortable-media-surfer", branch: "fix-redactor" but then bundle fails with /bin/sh: esbuild: command not found

actually for it to work straight from github we"d have to add the compiled assets to git.

the alternative is to check out the surfer repo and reference it in your app's Gemfile via path instead of git. This way you can compile the assets locally in the surfer directory.

what should it be?

@Judahmeek , @justin808 - what do you guys think about Alex's query, viz. add the compiled assets to source control in order to be able to reference the repo in a Gemfile, or not.

@avonderluft personally, I think the decision is up to you since you've been the primary maintainer.

I've pinged Justin on Slack regarding this conversation, however, so we should have his opinion soon.

Is there any alternative to avoid the duplication of including the compiled assets in git?

There are many reasons that compiled assets in the version history is annoying and to be avoided.

Potentially we could build it as part of the gem?

@justin808 that was my other idea. Create a Rake task to compile the assets when building the gem. The downside is that when you try to use the gem in a Gemfile via git the gem has not een built and so the assets are missing.

I could also try to make compiling the assets in the .gemspec file more robust, e.g. by also installing npm packages within it. But imho there would always be gaps.

Turns out there is a post install hook for gems. Will try that.

should all be working now.

there is one strange issue where the post install hook is running (many) multiple times. see https://github.com/shakacode/comfortable-media-surfer/actions/runs/12868758577/job/35876086348?pr=11. don't have time to look into this any further today.

there is one strange issue where the post install hook is running (many) multiple times. see https://github.com/shakacode/comfortable-media-surfer/actions/runs/12868758577/job/35876086348?pr=11. don't have time to look into this any further today.

It is a little strange, but it looks like it might be concurrency-safe, as the first job, Tests (Ruby 3.2, Rails 7.2) in this case to start creating the cache apparently creates some kind of mutex that stops other jobs from trying to do the same thing.

asset compiling ran 100 times. maybe the hook runs for every gem that is installed.

I removed the post_install hook and added a Rake task that needs to be run manually instead.

@langalex @Judahmeek - I will try to get to this review soon, been quite busy. In the meantime @langalex could you squash the commits in anticipation of merging?

@langalex could you squash the commits in anticipation of merging?

done