Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiPrecisionAkkaActorBenchmark uses AtomicInteger for numWorkersTerminated #1

Open
smarr opened this issue Aug 5, 2015 · 1 comment

Comments

@smarr
Copy link

smarr commented Aug 5, 2015

Not sure why this benchmark uses an atomic integer, seems to be overkill, no? I would expect this to be already safe: https://github.com/shamsmahmood/savina/blob/master/src/main/scala/edu/rice/habanero/benchmarks/piprecision/PiPrecisionAkkaActorBenchmark.scala#L53

@smarr
Copy link
Author

smarr commented Nov 24, 2015

Similar issue are in the SleepingBarber and Philosopher benchmark. They use shared Atomics for communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant