Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Unbalanced Cobwebbed Tree benchmark uses a busy loop that is likely to be removed by a compiler #3

Open
smarr opened this issue Sep 28, 2015 · 1 comment

Comments

@smarr
Copy link

smarr commented Sep 28, 2015

The busy loop just increments the counter, and returns it. For some reason it also gets currentTimeMillis, but does not use it.
If a JIT compiler performance inlining and sees that the return value is never used, the loop is easily removed, which is probably not desirable, because, I guess this is part of the 'parallel work load' in tryGenerateChildren(), traverse(), and urgentTraverse().

https://github.com/shamsmahmood/savina/blob/master/src/main/java/edu/rice/habanero/benchmarks/uct/UctConfig.java#L64

@smarr
Copy link
Author

smarr commented Sep 29, 2015

There seem to be other issues with the benchmarks, the whole urgentTraversal/urgentChild notion seems to be unused. At least, I don't see how this code path is ever taken. Is this something essential?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant