Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make_data.py issues #3

Open
JudicaelPoumay opened this issue May 19, 2020 · 0 comments
Open

Make_data.py issues #3

JudicaelPoumay opened this issue May 19, 2020 · 0 comments

Comments

@JudicaelPoumay
Copy link

JudicaelPoumay commented May 19, 2020

EDIT : This seems to only matter for windows user

Line 60 is in python 2.x while the rest of the project is in python 3.x
Line 58 open the file in binary which does not work since the CSV is not a binary
Line 447 hidden files such as ".DS_Store" will result in an error, I propose to modify the line to dirs_int = [int(dir) for dir in dirs if dir.isdigit()]
Line 386,389 text variable needs to be decoded into utf-8 with text.decode("utf-8")
Line 395 I get an AttributeError when obj is a bytes ( I assume it should not be ). I decided to catch the error and return the byte decoded to utf-8 which works.

Also in windows many file opening needs an explicit encoding parameter Line 218 & 58 (that's just python being annoying).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant