-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Ledger THORChain & Cosmos app open request #6806
Comments
Cormos is in the same boat, debug this at the same time 🙏 |
When attempting to manage accounts for thorchain or cosmos, the app crashes due to missing support for This issue never presented in web previously because we never attempt to validate the correct app being open on ledger, and instead swallow errors (hence the requirement for the new The workaround here is to bypass this check and allow the user to attempt to proceed, then display an error toast if account fetching fails. We'll have to follow up with a fix in hdwallet and remove this temporary patch. |
Once shapeshift/hdwallet#670 is merged, will have to follow up in web and remove the patches. |
Detecting if the THORChain app is open on Ledger is currently broken, which I suspect is caused by
await this.transport.call(null, "getAppAndVersion")
returningTHORChain
, whereas the slip key is written asThorchain
in HDWallet'sslip44Table
(I suspect incorrectly, asSLIP-0044
lists it asTHORChain
too).This might require a slight tweak in HDWallet.
The text was updated successfully, but these errors were encountered: