Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite Spike #8812

Open
0xean opened this issue Feb 12, 2025 · 1 comment · May be fixed by #8924
Open

Vite Spike #8812

0xean opened this issue Feb 12, 2025 · 1 comment · May be fixed by #8924
Assignees
@NeOMakinG
Labels
spike

Comments

@0xean
Copy link
Contributor

0xean commented Feb 12, 2025 •
edited
Loading

Vite is faster... we all want Vite...

lets make sure we want to take on this work:

Spend <.5 day on researching some risks to migrations:

  • potential reasons that we might not be able to migrate
  • Vite performance on large web apps
  • any implications for the mobile app (shouldn't be)
  • document any findings in gist or here and we can kick of the work in earnest
  • review with team and create ticket to start actual work
@0xean 0xean added the spike label Feb 12, 2025
@0xean 0xean moved this from Backlog to Up next / groomed in ShapeShift Dashboard Feb 12, 2025
@NeOMakinG NeOMakinG self-assigned this Feb 20, 2025
@NeOMakinG NeOMakinG moved this from Up next / groomed to In progress in ShapeShift Dashboard Feb 20, 2025
@NeOMakinG NeOMakinG linked a pull request Feb 24, 2025 that will close this issue
Open
1 task
@NeOMakinG
Copy link
Collaborator

So finally, I opened the vite PR, it was pretty difficult to spike it, I couldn't see any blockers so far but what was the point to list the steps and say "we shouldn't meet any blockers so far"

Considering the current weird focus time, I took around 3 days to open the PR:

Full details here but not blockers so far: #8924

To be discussed:

  • circular dependency plugin
  • env variable leveraging vite instead of the static generation (in a follow up)
  • root path to @/
  • mono repo packages from @shapeshiftoss to @shapeshiftmonorepo

@NeOMakinG NeOMakinG moved this from In progress to In review in ShapeShift Dashboard Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeOMakinG NeOMakinG

Labels
spike
Projects
ShapeShift Dashboard
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use vite instead of react-app-rewired shapeshift/web
2 participants
@NeOMakinG @0xean