-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "-" buttons on Mission Menu #38
Comments
You can edit the value manually. + don't add pairs, it add double of what you have in stock. Given that you'd usually scramble only 2-4 aircraft but armor would go in bigger amounts (8-16) that feature seems fine to me. As for the minus - guess I could add it, its not that big of a deal. |
I think this menu could use the Tkinter Spinbox widget instead of the Entry + a Button. With the Spinbox you can also actually cap and limit the values too, which is another issue with the current implementation. ( And i have to admit that i've always been confused by the plus button behaviour too. ) |
Even though aircraft fly in pairs, there's scenarios where this doesn't apply - for example when an airfield has an odd number of aircraft available, and you want to send all of them. Or if a user flies solo, and there's more than one aircraft available. Furthermore, there's no discernible convention - the input fields and buttons look the same, but act differently - some add 1, some 2, some 8. Makes it confusing. A slider or multiple buttons would make a lot more sense IMO. Replacing the text field with a non-editable UI element would also prevent the user from inputting invalid data, like selecting a larger number of aircraft than available. Specifically - these changes would conform to Nielsen's "Error Prevention" and "Recognition rather than Recall" |
Well, the criticism is valid, although I don't want to spend the limited development time on this, to be honest, not on this stage. Also code behind UI would prevent using more than units that available obviously. |
* if client slots are below amount, amount slots will be incremented * if amount is below client, client slots will be decremented #38
* plus now adds 1 plane instead of half available * added a minus button (which removes one unit)
Once some units are added to the upcoming mission, the units cannot be lowered. The "+" button should also add single units, not in pairs.
The text was updated successfully, but these errors were encountered: