Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "-" buttons on Mission Menu #38

Open
linmar22 opened this issue Oct 27, 2018 · 4 comments
Open

Add "-" buttons on Mission Menu #38

linmar22 opened this issue Oct 27, 2018 · 4 comments
Assignees
Labels

Comments

@linmar22
Copy link

Once some units are added to the upcoming mission, the units cannot be lowered. The "+" button should also add single units, not in pairs.

@shdwp
Copy link
Owner

shdwp commented Oct 27, 2018

You can edit the value manually. + don't add pairs, it add double of what you have in stock. Given that you'd usually scramble only 2-4 aircraft but armor would go in bigger amounts (8-16) that feature seems fine to me.

As for the minus - guess I could add it, its not that big of a deal.

@shdwp shdwp added the enhancement New feature or request label Oct 27, 2018
@Khopa
Copy link
Collaborator

Khopa commented Oct 28, 2018

I think this menu could use the Tkinter Spinbox widget instead of the Entry + a Button. With the Spinbox you can also actually cap and limit the values too, which is another issue with the current implementation.

( And i have to admit that i've always been confused by the plus button behaviour too. )

@linmar22
Copy link
Author

Even though aircraft fly in pairs, there's scenarios where this doesn't apply - for example when an airfield has an odd number of aircraft available, and you want to send all of them. Or if a user flies solo, and there's more than one aircraft available. Furthermore, there's no discernible convention - the input fields and buttons look the same, but act differently - some add 1, some 2, some 8. Makes it confusing. A slider or multiple buttons would make a lot more sense IMO. Replacing the text field with a non-editable UI element would also prevent the user from inputting invalid data, like selecting a larger number of aircraft than available. Specifically - these changes would conform to Nielsen's "Error Prevention" and "Recognition rather than Recall"

@shdwp
Copy link
Owner

shdwp commented Oct 30, 2018

Well, the criticism is valid, although I don't want to spend the limited development time on this, to be honest, not on this stage.

Also code behind UI would prevent using more than units that available obviously.

@wrycu wrycu self-assigned this Mar 28, 2020
wrycu pushed a commit that referenced this issue Mar 29, 2020
* if client slots are below amount, amount slots will be incremented
* if amount is below client, client slots will be decremented

#38
wrycu referenced this issue Mar 29, 2020
wrycu referenced this issue Mar 29, 2020
* plus now adds 1 plane instead of half available
* added a minus button (which removes one unit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants