From d894da852a3260e410ec6321920cb35b32dcbf32 Mon Sep 17 00:00:00 2001
From: zheng-bin <wenwubinzheng@gmail.com>
Date: Tue, 14 Nov 2023 16:29:37 +0800
Subject: [PATCH] add msg check

---
 x/bounty/types/msgs.go | 57 ++++++++++++++++++++++++++++++++++++++----
 1 file changed, 52 insertions(+), 5 deletions(-)

diff --git a/x/bounty/types/msgs.go b/x/bounty/types/msgs.go
index 23f2e7968..bb0c5ebb7 100644
--- a/x/bounty/types/msgs.go
+++ b/x/bounty/types/msgs.go
@@ -69,6 +69,15 @@ func (msg MsgCreateProgram) ValidateBasic() error {
 	if err != nil {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid issuer address (%s)", err.Error())
 	}
+	if len(msg.ProgramId) == 0 {
+		return errors.New("empty programId is not allowed")
+	}
+	if len(msg.Name) == 0 {
+		return errors.New("empty name is not allowed")
+	}
+	if len(msg.Detail) == 0 {
+		return errors.New("empty detail is not allowed")
+	}
 	return nil
 }
 
@@ -115,6 +124,9 @@ func (msg MsgEditProgram) ValidateBasic() error {
 	if err != nil {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid issuer address (%s)", err.Error())
 	}
+	if len(msg.ProgramId) == 0 {
+		return errors.New("empty programId is not allowed")
+	}
 	return nil
 }
 
@@ -164,7 +176,19 @@ func (msg MsgSubmitFinding) ValidateBasic() error {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid issuer address (%s)", err.Error())
 	}
 	if len(msg.ProgramId) == 0 {
-		return errors.New("empty pid is not allowed")
+		return errors.New("empty programId is not allowed")
+	}
+	if len(msg.FindingId) == 0 {
+		return errors.New("empty findingId is not allowed")
+	}
+	if len(msg.Title) == 0 {
+		return errors.New("empty title is not allowed")
+	}
+	if len(msg.FindingHash) == 0 {
+		return errors.New("empty findingHash is not allowed")
+	}
+	if !ValidFindingSeverityLevel(msg.SeverityLevel) {
+		return sdkerrors.Wrap(ErrFindingSeverityLevelInvalid, msg.SeverityLevel.String())
 	}
 	return nil
 }
@@ -216,6 +240,15 @@ func (msg MsgEditFinding) ValidateBasic() error {
 	if len(msg.FindingId) == 0 {
 		return errors.New("empty fid is not allowed")
 	}
+	if len(msg.Title) == 0 {
+		return errors.New("empty title is not allowed")
+	}
+	if len(msg.FindingHash) == 0 {
+		return errors.New("empty findingHash is not allowed")
+	}
+	if !ValidFindingSeverityLevel(msg.SeverityLevel) {
+		return sdkerrors.Wrap(ErrFindingSeverityLevelInvalid, msg.SeverityLevel.String())
+	}
 	return nil
 }
 
@@ -251,6 +284,9 @@ func (msg MsgActivateProgram) ValidateBasic() error {
 	if err != nil {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid address (%s)", err.Error())
 	}
+	if len(msg.ProgramId) == 0 {
+		return errors.New("empty programId is not allowed")
+	}
 	return nil
 }
 
@@ -286,6 +322,9 @@ func (msg MsgCloseProgram) ValidateBasic() error {
 	if err != nil {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid address (%s)", err.Error())
 	}
+	if len(msg.ProgramId) == 0 {
+		return errors.New("empty programId is not allowed")
+	}
 	return nil
 }
 
@@ -327,9 +366,11 @@ func (msg MsgConfirmFinding) ValidateBasic() error {
 	if err != nil {
 		return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "Invalid issuer address (%s)", err.Error())
 	}
-
 	if len(msg.FindingId) == 0 {
-		return errors.New("empty finding-id is not allowed")
+		return errors.New("empty findingId is not allowed")
+	}
+	if len(msg.Fingerprint) == 0 {
+		return errors.New("empty fingerprint is not allowed")
 	}
 	return nil
 }
@@ -373,7 +414,7 @@ func (msg MsgConfirmFindingPaid) ValidateBasic() error {
 	}
 
 	if len(msg.FindingId) == 0 {
-		return errors.New("empty finding-id is not allowed")
+		return errors.New("empty findingId is not allowed")
 	}
 	return nil
 }
@@ -417,7 +458,7 @@ func (msg MsgCloseFinding) ValidateBasic() error {
 	}
 
 	if len(msg.FindingId) == 0 {
-		return errors.New("empty finding-id is not allowed")
+		return errors.New("empty findingId is not allowed")
 	}
 	return nil
 }
@@ -465,5 +506,11 @@ func (msg MsgReleaseFinding) ValidateBasic() error {
 	if len(msg.FindingId) == 0 {
 		return errors.New("empty fid is not allowed")
 	}
+	if len(msg.Description) == 0 {
+		return errors.New("empty description is not allowed")
+	}
+	if len(msg.ProofOfConcept) == 0 {
+		return errors.New("empty proofOfConcept is not allowed")
+	}
 	return nil
 }