Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprocessing control. #2059

Open
2 tasks done
ghost opened this issue Mar 31, 2024 · 3 comments · May be fixed by #2070
Open
2 tasks done

Multiprocessing control. #2059

ghost opened this issue Mar 31, 2024 · 3 comments · May be fixed by #2070
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Mar 31, 2024

Checklist

  • I'm reporting a feature request
  • I've checked for similar feature requests including closed ones

Description

WRITE DESCRIPTION HERE:
I wish Sherlock have an alternative argument,"num_workers" for example，to let the user decide the usage of multiple cores.
@ghost ghost added the enhancement New feature or request label Mar 31, 2024
@rpwnage
Copy link

rpwnage commented Apr 4, 2024

So num_workers define the number of threads ran?

@ghost
Copy link
Author

ghost commented Apr 5, 2024

So num_workers define the number of threads ran?

Basically speaking, yes:)

@ppfeister ppfeister linked a pull request Apr 8, 2024 that will close this issue
Open
@ppfeister
Copy link
Member

fyi y'all, since that issue<->pr link was without clarification ---

If that pr gets merged then the new flag would be --workers with whatever number you want to be the maximum. Defaults to 20 as was the previous standard.

python3 sherlock.py --workers 40 hackerman1337 will run with 40 workers in that patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add maximum worker control ppfeister/sherlock
2 participants
@ppfeister @rpwnage