Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates and weights computations are spread out #14

Open
shervinea opened this issue Sep 10, 2021 · 0 comments
Open

Coordinates and weights computations are spread out #14

shervinea opened this issue Sep 10, 2021 · 0 comments
Labels

Comments

@shervinea
Copy link
Owner

Context. The pdb.py file encodes extraction-related operations. We need to ensure all extraction operations produce objects that are comparable with each other, as it is the hidden assumption behind the volume computation code volume.py.

Current behavior. Coordinates and weights are separately extracted following almost duplicate logic. There is no safeguard in place that prevents coordinates and weight output from not being comparable anymore.

Desired behavior. Coordinates and weights share a maximum amount of logic with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant