You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Trying to run php artisan config:cache on a project with this package installed fails because commit 10c3a1f introduced a not serializable value on the config file. The logger is now created on the config file instead of on the Service Provider.
Unless you have a very good reason for this, I can make a PR moving that code back to the service provider and restoring the logPath and logLevel on the config file. I guess I could make it backwards compatible that only if you don't have the logger on the config file it gets created on the service provider.
Let me know what you think.
The text was updated successfully, but these errors were encountered:
Hi @candasm, I'm using Laravel 6 and laravel-elasticsearch 4.5.1 although the issue will surface on Laravel 5 as well, since afaik the call to create the default logger from the builder class won't be serializable anyway.
Trying to run
php artisan config:cache
on a project with this package installed fails because commit 10c3a1f introduced a not serializable value on the config file. The logger is now created on the config file instead of on the Service Provider.Unless you have a very good reason for this, I can make a PR moving that code back to the service provider and restoring the
logPath
andlogLevel
on the config file. I guess I could make it backwards compatible that only if you don't have the logger on the config file it gets created on the service provider.Let me know what you think.
The text was updated successfully, but these errors were encountered: