New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaler(aws_ec2_asg): avoid multiple describe autoscaling group calls #21

Open

scriptnull opened this issue May 25, 2023 · 0 comments

Labels

area/scaler good first issue

Member

scriptnull commented May 25, 2023

When we evaluate a scaling event in aws_ec2_asg scaler, we are currently making the API call to get a list of ASGs twice.

https://github.com/scriptnull/waymond/blob/3dee33fba1f58cafae800d71d1a0efaa2f7c9e49/internal/scaler/awsec2asg/aws_ec2_asg.go#L118-L125

https://github.com/scriptnull/waymond/blob/3dee33fba1f58cafae800d71d1a0efaa2f7c9e49/internal/scaler/awsec2asg/aws_ec2_asg.go#L300-L307

This can be refactored to make it once if the ASG is detected in the first call spot.

scriptnull added good first issue area/scaler labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment