Skip to content

Commit

Permalink
Removes the ability for players to use a table's background attribute…
Browse files Browse the repository at this point in the history
… in html to embed images (#2383)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

a table has a background attribute which can render images from links

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

security issue bad

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
del: you can no longer bypass image sanitization with tables
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
meemofcourse authored Sep 30, 2023
1 parent 27af6f1 commit 07db71b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tgui/packages/tgui/sanitize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const defTag = [
// Advanced HTML tags that we can trust admins (but not players) with
const advTag = ['img'];

const defAttr = ['class', 'style'];
const defAttr = ['class', 'style', 'background'];

/**
* Feed it a string and it should spit out a sanitized version.
Expand Down

0 comments on commit 07db71b

Please sign in to comment.