Skip to content

Commit

Permalink
Fixes broken mapping versions of volume pumps for SDMM (#3118)
Browse files Browse the repository at this point in the history
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
fixes path error for mapping versions of volume pumps and correctly
renames volume pump mapping icons

![image](https://github.com/shiptest-ss13/Shiptest/assets/90987989/10cea549-efb6-4e3e-ba60-183ec21d7cad)

![image](https://github.com/shiptest-ss13/Shiptest/assets/90987989/48042aa0-e6d0-482c-8fe5-b7f09119736c)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes volume pumps that start on have the on texture in sdmm, and makes
the layer versions correctly show up in sdmm.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: fixed volume pumps for mapping.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
  • Loading branch information
Thera-Pissed authored Jun 21, 2024
1 parent 1e2fefe commit 84c1b8d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,18 +204,18 @@
piping_layer = 2
icon_state = "volpump_map-2"

/obj/machinery/atmospherics/components/binary/volume_pump/layer2
piping_layer = 2
icon_state = "volpump_map-2"
/obj/machinery/atmospherics/components/binary/volume_pump/layer4
piping_layer = 4
icon_state = "volpump_map-4"

/obj/machinery/atmospherics/components/binary/volume_pump/on
on = TRUE
icon_state = "volpump_map-2"
icon_state = "volpump_on_map-3"

/obj/machinery/atmospherics/components/binary/volume_pump/on/layer2
piping_layer = 2
icon_state = "volpump_map-2"
icon_state = "volpump_on_map-2"

/obj/machinery/atmospherics/components/binary/volume_pump/on/layer4
piping_layer = 4
icon_state = "volpump_map-4"
icon_state = "volpump_on_map-4"
Binary file modified icons/obj/atmospherics/components/binary_devices.dmi
Binary file not shown.

0 comments on commit 84c1b8d

Please sign in to comment.