From 867c9e5bb0a7f72b8aa7bcd4d441e5845eac855a Mon Sep 17 00:00:00 2001
From: meem <75212565+meemofcourse@users.noreply.github.com>
Date: Thu, 29 Aug 2024 08:08:55 -0400
Subject: [PATCH] Raises character slot limit to 30 (#3089)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

![imagen](https://github.com/shiptest-ss13/Shiptest/assets/75212565/9dd55f82-55d4-47c6-b1f9-bf6597d78cf6)
mark was wrong god save us all

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
You know how we encourage playing different characters for the multiple
factions?

Currently, we have 6 player factions (CLIP, PGF, NT, SRM, Inteq, SolCon)
plus 6 branches of the Syndicate (ACLF, Cybersun, Hardliners, SUNS, NGR,
GEC) and 2 special factions (Fronties, Ramzi). If I wanted two
characters for each faction (officer, assistant, medic, whatever) and
one for each special faction, I'd need 26 slots. 40 seems good.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Character slots have been raised to 40. BYOND members get 50.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: rye-rice <58402542+rye-rice@users.noreply.github.com>
Co-authored-by: rye-rice <58402542+rye-rice@users.noreply.github.com>
---
 code/modules/client/preferences.dm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/modules/client/preferences.dm b/code/modules/client/preferences.dm
index 317828283dbd..ec5b7d188db0 100644
--- a/code/modules/client/preferences.dm
+++ b/code/modules/client/preferences.dm
@@ -5,7 +5,7 @@ GLOBAL_LIST_EMPTY(preferences_datums)
 	//doohickeys for savefiles
 	var/path
 	var/default_slot = 1				//Holder so it doesn't default to slot 1, rather the last one used
-	var/max_save_slots = 20
+	var/max_save_slots = 30
 
 	//non-preference stuff
 	var/muted = 0
@@ -227,7 +227,7 @@ GLOBAL_LIST_EMPTY(preferences_datums)
 			load_path(C.ckey)
 			unlock_content = C.IsByondMember()
 			if(unlock_content)
-				max_save_slots = 30
+				max_save_slots = 50
 	var/loaded_preferences_successfully = load_preferences()
 	if(loaded_preferences_successfully)
 		if(load_character())