From c8d382827e99150476cec6e4b9ca71390373d3b8 Mon Sep 17 00:00:00 2001 From: Patrick Meade Date: Fri, 21 Jun 2024 02:51:40 -0500 Subject: [PATCH] Remove superfluous logic in revolver/rack() (#3127) ## About The Pull Request I was reviewing `revolver.dm` and noticed a bit of duplicated logic. While "twice to be sure" is usually a good idea for using a gun, it's probably not necessary here. ## Why It's Good For The Game Clean code is good code? ## Changelog :cl: fix: Cleaned up some logic in revolver safety /:cl: --- code/modules/projectiles/guns/ballistic/revolver.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/modules/projectiles/guns/ballistic/revolver.dm b/code/modules/projectiles/guns/ballistic/revolver.dm index c19c03f31e3eb..034e12ca65cdf 100644 --- a/code/modules/projectiles/guns/ballistic/revolver.dm +++ b/code/modules/projectiles/guns/ballistic/revolver.dm @@ -282,7 +282,7 @@ to_chat(user, "You rack the [bolt_wording] of \the [src].") playsound(src, rack_sound, rack_sound_volume, rack_sound_vary) - if((!safety && !semi_auto) || (!safety && !semi_auto)) + if(!safety && !semi_auto) chamber_round(TRUE) SEND_SIGNAL(src, COMSIG_UPDATE_AMMO_HUD) update_appearance()