Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moth language is broken and shows ,m when speaking with the prefix #2407

Closed
randyfromrimworld opened this issue Oct 16, 2023 · 1 comment · Fixed by #2414
Closed

Moth language is broken and shows ,m when speaking with the prefix #2407

randyfromrimworld opened this issue Oct 16, 2023 · 1 comment · Fixed by #2414
Labels
Bug Something isn't working

Comments

@randyfromrimworld
Copy link

Reproduction:

Moth language is bugged when using the ,m prefix.
When speaking, the chat menu and the runetext will show ,m in the text, instead of disappearing as it does in other languages.
This does not occur when using the language menu to set a default language.

Example:
*say ,m we need to kill the captain!
Moth says, ",m we need to kill the captain!"
Intended:
*say ,m we need to kill the captain!
Moth says, "We need to kill the captain!"
@randyfromrimworld randyfromrimworld added the Bug Something isn't working label Oct 16, 2023
@randyfromrimworld randyfromrimworld changed the title [BUG] Moth language is broken and shows ,m when speaking with the prefix Oct 16, 2023
@CloudyNewt
Copy link

Seems like the issue is a shared language key. Should be easy enough to fix!

@Skies-Of-Blue Skies-Of-Blue mentioned this issue Oct 19, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 20, 2023
@Skies-Of-Blue
Fixes Moth Language Bind (#2414)
e08a906 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Resolves #2407 by
removing the overlap between mouse and moth language binds.

## Why It's Good For The Game

Squashes bugs (the nasty kind, not the lovable kind).
You can now #%,m once again without destroying your immersion. Rejoice!

## Changelog

:cl:
fix: moth language bind now works as intended
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Moth Language Bind Skies-Of-Blue/Shiptest
2 participants
@CloudyNewt @randyfromrimworld