Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghosts can click on containers to open them and make sounds that can be heard by the living #2417

Closed
Zevotech opened this issue Oct 20, 2023 · 2 comments
Closed

Ghosts can click on containers to open them and make sounds that can be heard by the living #2417

Zevotech opened this issue Oct 20, 2023 · 2 comments

Comments

@Zevotech
Copy link
Contributor

Issue reported from Round ID: 1950 (Shiptest)

Reporting client version: 514.1589

Ghosts clicking on a container to open it seems to play the sound of the container opening locally to anyone nearby, including other ghosts and living players.

  1. Gather circle of ghosts around a leather satchel and spamclick it
  2. Realize in horror that people can hear it opening repeatedly
  3. Make a bug report like a rational person
@thestripes thestripes mentioned this issue Oct 20, 2023
Closed
@thestripes
Copy link
Contributor

image
noted here with the message in question

@thestripes
Copy link
Contributor

Another update to this bug report as it falls under the same jurisdiction: ghosts can open boxes and the sound transmits as well

BogCreature added a commit to BogCreature/Shiptest that referenced this issue Oct 20, 2023
@BogCreature
Fixes issue shiptest-ss13#2417
ec8b74a
@BogCreature BogCreature mentioned this issue Oct 22, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 26, 2023
@BogCreature
Fixes Ghosts Haunting People's Bags (#2421)
890e1c5 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Should fix issue #2417 and the related issue of opening sounds playing
twice when alt + clicking them.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
As incredibly funny as it is to haunt people as a ghost, it's probably
not overall good for the dead to be able to interact with the living.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: ghosts playing container sounds
fix: some container sounds playing twice
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Imaginos16 @Zevotech @thestripes