Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] At least one drink fails to get a sprite when mixed in a glass, then fails to revert back #3132

Closed
thestripes opened this issue Jun 20, 2024 · 1 comment · Fixed by #3133
Closed

[BUG] At least one drink fails to get a sprite when mixed in a glass, then fails to revert back #3132

thestripes opened this issue Jun 20, 2024 · 1 comment · Fixed by #3133
Labels
Bug Something isn't working

Comments

@thestripes
Copy link
Contributor

ROUND ID: 2459

Reproduction:

  1. Mix a mixed drink, specifically in this bug, the Tadrixx Float.
  2. Pour into a drinking glass.
  3. The glass becomes invisible, and on turf menu and right click it shows every single drink sprite on the .dmi.
  4. Drink it, placing it back down to reveal that the glass isn't reverting back into being a generic glass.
@thestripes thestripes added the Bug Something isn't working label Jun 20, 2024
@generalthrax
Copy link
Contributor

After checking I noticed that the Tadrixx Float was using an icon called "tadrixxfloat" that didnt exist. I'll fix this in like 2

@generalthrax generalthrax mentioned this issue Jun 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 21, 2024
@generalthrax
tadrixxfloat has a sprite now (#3133)
09022aa 
## About The Pull Request

fixes #3132

## Why It's Good For The Game

missing sprites bad, i might go through drinks and see if any other are
Fucked later

## Changelog

:cl:
fix: Tadrixx Float has a sprite again
/:cl:
@MysticalFaceLesS MysticalFaceLesS mentioned this issue Jun 21, 2024
Closed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this issue Jun 22, 2024
@generalthrax @MrCat15352
tadrixxfloat has a sprite now (shiptest-ss13#3133)
23558a3 
fixes shiptest-ss13#3132

missing sprites bad, i might go through drinks and see if any other are
Fucked later

:cl:
fix: Tadrixx Float has a sprite again
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@thestripes @generalthrax