Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardliner Pilot and Hardliner Trooper are the same typepath #3272

Closed
Luftkommando opened this issue Aug 3, 2024 · 0 comments · Fixed by #3273
Closed

Hardliner Pilot and Hardliner Trooper are the same typepath #3272

Luftkommando opened this issue Aug 3, 2024 · 0 comments · Fixed by #3273
Labels
Bug Something isn't working

Comments

@Luftkommando
Copy link
Contributor

Round ID:

2580

Testmerges:

#3145: 'Destructible Walls' by Gristlebee at commit 7cfdc2eb2a
#3006: 'Remaps the Dwayne.' by Sadhorizon at commit ba12e65107
#3094: 'tweaks to recoil and spread' by FalloutFalcon at commit dbae8b50e4
#2988: 'Claymores & Mine Tweaks' by Sun-Soaked at commit c18e1e8c09
#3180: 'Hazardous Gases (Cl and HCl)' by Thera-Pissed at commit 51b478c822
#3218: 'Revert "orbit menu is less cluttered"' by thgvr at commit 65c34836ba
#3239: 'The Particlening' by rye-rice at commit e93ed81c86
#3238: 'refresh:clip p.3/frontiersmenening p.2: clip vs frontiersmen' by rye-rice at commit e21d8c309a
#3249: 'Back In Black (Market) - Black Market Dead Drops and Stock Cycling' by Gristlebee at commit ac8dd4a4b7
#3246: 'Atlas-class Light Armored Crusier' by meemofcourse at commit 69b68cb316
#3220: 'TEG efficiency code tweaks.' by Thera-Pissed at commit 8c32603f29
#3266: 'makes lighting a bit moodier' by tmtmtl30 at commit a0ce76c4be

Reproduction:

wires

/datum/outfit/job/syndicate/security/gorlex
	name = "Syndicate - Trooper (Hardliner)"
	id_assignment = "Trooper"
	job_icon = "securityofficer"

	uniform = /obj/item/clothing/under/syndicate/hardliners
	belt = /obj/item/storage/belt/security/webbing/hardliners
	suit = /obj/item/clothing/suit/armor/hardliners
	gloves = /obj/item/clothing/gloves/color/black
	head = /obj/item/clothing/head/helmet/hardliners
	shoes = /obj/item/clothing/shoes/combat
	l_pocket = /obj/item/restraints/handcuffs
	r_pocket = /obj/item/assembly/flash/handheld

/datum/outfit/job/syndicate/security/gorlex
	name = "Syndicate - Pilot (Hardliner)"
	id_assignment = "Pilot"
	job_icon = "securityofficer"

	head = /obj/item/clothing/head/helmet/hardliners/swat
@Luftkommando Luftkommando added the Bug Something isn't working label Aug 3, 2024
@meemofcourse meemofcourse mentioned this issue Aug 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 17, 2024
@meemofcourse
Hardliner Pilot and Hardliner Trooper are no longer the same typepath (…
c0f0fbe 
…#3273)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
title. closes #3272 

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: Hardliner troopers should no longer spawn as Hardliner pilots
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this issue Aug 19, 2024
@meemofcourse @MysticalFaceLesS
Hardliner Pilot and Hardliner Trooper are no longer the same typepath (…
5f0b679 
…shiptest-ss13#3273)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
title. closes shiptest-ss13#3272 

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: Hardliner troopers should no longer spawn as Hardliner pilots
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hardliner Pilot and Hardliner Trooper are no longer the same typepath meemofcourse/Shiptest
1 participant
@Luftkommando