Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Throw_range only goes halfway #3487

Closed
generalthrax opened this issue Oct 6, 2024 · 1 comment
Closed

[BUG] Throw_range only goes halfway #3487

generalthrax opened this issue Oct 6, 2024 · 1 comment
Labels
Bug Something isn't working

Comments

@generalthrax
Copy link
Contributor

Reproduction:

On items that have throw_range (hand grenades, knives, spears), they'll have a throw range of, say, 6 or 8 or something. In practice, it'll be more like 3 and 4.

Spawn a weapon intending to be thrown
Check its throw range
Throw it
Notice it only goes halfway

This is probably not intended and I'm not really sure whats wrong
@generalthrax generalthrax added the Bug Something isn't working label Oct 6, 2024
@zimon9 zimon9 mentioned this issue Oct 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 12, 2024
@zimon9
Resolves issue #3487 -- Throwing bug fix (#3522)
d2a8cbe 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This fix removes a second increment to the dist_travelled variable. This
line appears to have caused the throwing range of items to be halved,
effectively. This fix should make it so that thrown objects go as far as
they are intended to.

## Why It's Good For The Game

Resolves the issue linked here:
#3487

## Changelog

:cl:
fix: fixed halved throw range
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
zimon9 added a commit to zimon9/Shiptest-PR-testing that referenced this issue Oct 29, 2024
@zimon9
Resolves issue shiptest-ss13#3487 -- Throwing bug fix (shiptest-ss13#…
3188da5 
…3522)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This fix removes a second increment to the dist_travelled variable. This
line appears to have caused the throwing range of items to be halved,
effectively. This fix should make it so that thrown objects go as far as
they are intended to.

## Why It's Good For The Game

Resolves the issue linked here:
shiptest-ss13#3487

## Changelog

:cl:
fix: fixed halved throw range
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Constellado pushed a commit to Constellado/PentestDevelopment that referenced this issue Nov 19, 2024
@zimon9 @Constellado
Resolves issue #3487 -- Throwing bug fix (#3522)
3212f73 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This fix removes a second increment to the dist_travelled variable. This
line appears to have caused the throwing range of items to be halved,
effectively. This fix should make it so that thrown objects go as far as
they are intended to.

## Why It's Good For The Game

Resolves the issue linked here:
shiptest-ss13/Shiptest#3487

## Changelog

:cl:
fix: fixed halved throw range
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@MarkSuckerberg
Copy link
Member

fixed in #3522

Constellado pushed a commit to Constellado/PentestDevelopment that referenced this issue Nov 22, 2024
@zimon9 @Constellado
Resolves issue #3487 -- Throwing bug fix (#3522)
01741df 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This fix removes a second increment to the dist_travelled variable. This
line appears to have caused the throwing range of items to be halved,
effectively. This fix should make it so that thrown objects go as far as
they are intended to.

## Why It's Good For The Game

Resolves the issue linked here:
shiptest-ss13/Shiptest#3487

## Changelog

:cl:
fix: fixed halved throw range
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Constellado pushed a commit to Constellado/PentestDevelopment that referenced this issue Nov 25, 2024
@zimon9 @Constellado
Resolves issue #3487 -- Throwing bug fix (#3522)
550a18e 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This fix removes a second increment to the dist_travelled variable. This
line appears to have caused the throwing range of items to be halved,
effectively. This fix should make it so that thrown objects go as far as
they are intended to.

## Why It's Good For The Game

Resolves the issue linked here:
shiptest-ss13/Shiptest#3487

## Changelog

:cl:
fix: fixed halved throw range
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkSuckerberg @generalthrax