Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.300 magnum stripper clips don't work on the Scout. #3536

Closed
IHaveNoOriginality opened this issue Oct 11, 2024 · 0 comments · Fixed by #3649
Closed

.300 magnum stripper clips don't work on the Scout. #3536

IHaveNoOriginality opened this issue Oct 11, 2024 · 0 comments · Fixed by #3649

Comments

@IHaveNoOriginality
Copy link

Issue reported from Round ID: 2752 (Shiptest)

Reporting client version: 515.1643

It straight up doesn't let you interact with the rifle if you use a clip on it.
@MarkSuckerberg MarkSuckerberg mentioned this issue Oct 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2024
@SomeguyManperson
Fixes strippers not working (#3649)
4d92b54 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Fixes #3536
Fixes #3547

Ammo stacks added a check to prevent magazine to magazine filling which
also prevented directly filling guns with anything that wasnt an ammo
stack, which broke stripper clips and speedloaders. Revolvers escaped
this since they handle everything related to loading completely
differently.

This moves the strict ammo stack check down a bit so ammo holders that
are able to instantly transfer ammo between eachother can instead of
dont

## Changelog

:cl:
fix: strippers and speedloaders for rifles now work again
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Theos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes strippers not working SomeguyManperson/Shiptest
1 participant
@IHaveNoOriginality