Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]If you click fast enough you can accept and decline a mission in the Available Missions screen #3700

Closed
Ratvarr opened this issue Nov 3, 2024 · 0 comments · Fixed by #3707
Labels
Bug Something isn't working

Comments

@Ratvarr
Copy link

Ratvarr commented Nov 3, 2024

Round ID: Has happened multiple rounds before

Testmerges:

#3016: 'Tegu-class Communications Freighter' by goober3 at commit 98b25af4e7
#3624: 'New Ship: Woeful Cthonian-class Patrol Cutter' by Erikafox at commit 91a04becf9
#3554: 'NGR Kali Andhi-class Destroyer' by Apogee-dev at commit 1914efc596
#3461: 'click cooldown hud' by FalloutFalcon at commit 7d3381cc46
#3695: 'Small Stat Tweaks' by MarkSuckerberg at commit 87ddab111f

Reproduction:

Have a probably broken mouse, or auto clicker, or some way to click hyper fast.
Accept a mission, and watch it instantly give it up.
Want to die.

@Ratvarr Ratvarr added the Bug Something isn't working label Nov 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Fixes #3700 by requiring a confirmation pop up to give up on missions.
Minor QoL.

## Why It's Good For The Game

Prevents people from accidentally abandoning missions when they didn't
mean to, and provides more time to reconsider it.

## Changelog

:cl:
add: Added a confirmation pop up for abandoning missions.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant