Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]Radiation waste barrel sprites have.. Reversed? #3990

Closed
Ratvarr opened this issue Jan 12, 2025 · 2 comments · Fixed by #4022
Closed

[BUG]Radiation waste barrel sprites have.. Reversed? #3990

Ratvarr opened this issue Jan 12, 2025 · 2 comments · Fixed by #4022
Labels
Bug Something isn't working

Comments

@Ratvarr
Copy link
Contributor

Ratvarr commented Jan 12, 2025

Round ID:

3029

Testmerges:

Server revision compiled on:
Master commit: f77b347bbf4daa2695ad964541048f9270e421d8
The following pull requests are currently test merged:
#3887: 'Faction Cargo: Armor' by Erikafox at commit dc01f9d57b
#3910: 'Arke-Class Surveying Ship | CLIP-LAND' by Ical92 at commit 601f412c0f
#3950: 'Port: Datumized AI and JPS' by FalloutFalcon at commit 6cb75a13bf
#3589: 'Robotic limb degradation' by TDHooligan at commit 190aca0013
#3736: 'Gun Zoom Changes' by Erikafox at commit f98fd1f13c
#3744: 'Phantom-Class Mining Courier (Hardliner)' by miniusAreas at commit e1f7fe71cc
#3895: '[DNM] Partial Tempchanges Revert' by Erikafox at commit d1e347503d
#3976: 'New Ship: Nimbus-Class Caravel' by Erikafox at commit fbb34e202d
#3968: 'Libertatia 2' by Apogee-dev at commit e9ca397158
Local commit: f1f2f085e9c118413c57540e8bcae63818635bf8

Reproduction:

I don't know.
image
Here's an image of it.
It should not be like this because these are the sprites from #146 this PR.
It should not be doing this. Something is wrong.
@Ratvarr Ratvarr added the Bug Something isn't working label Jan 12, 2025
@Ratvarr
Copy link
Contributor Author

Ratvarr commented Jan 13, 2025

found the potential cause , #3233 touches the radioactive waste code, -as per VSC- which does.. Something to them

@Ratvarr
Copy link
Contributor Author

Ratvarr commented Jan 13, 2025

testing on localhost updated to current era confirms that the sprites are the old versions

@SomeguyManperson SomeguyManperson mentioned this issue Jan 17, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@SomeguyManperson
fix #3990 (#4022)
d9074f1 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

fixes #3990

## Why It's Good For The Game

old sprites were copied into the new hazard icons instead of the new
ones

## Changelog

:cl:
fix: radioactive barrels are now 4k HD again
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #3990 SomeguyManperson/Shiptest
1 participant
@Ratvarr