-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDB IGNORE]Kepori Visual Overhaul #2892
Conversation
this will be breast in 2027 |
Wear that is not aligned that I have found so far:
|
Take note of my TODOs in the pr body |
Blood overlays I have no idea how to set up framework for new ones, gotta think about it |
prosthetics are now "good enough" |
Probably go for underwear parity then call this done |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
It's "done" |
Character appearance is missing the Character Adjective when kepori species is selected. Changing to another species is a workaround to get it to show and change it. |
The reason I mentioned this is some hats do work, I just didn't have anything else to test with. So something weird is going on. |
CHECK_USE_AUTOGEN, go fuck yourself |
Ok so testing those latest changes, everything looks like its working properly wear wise (well, the stuff we have sprites for anyways. underwears don't work). I didnt do a 100% every single item test, but enough to touch on many that were having issues at one point or another. There is one more thing: This is still missing: Elzuose character screen: Kepori screen: I have no way of selecting the adj while kepori species is selected, though I can work around it by selecting another species then back to kepori again. There's also other stuff that appears in that column that is inaccessible while kepori is selected as well (like phobia quirk) EDIT: PR up for this PR to fix the missing preferences: thgvr#4 |
…how depending on species (ex phobias and character adjective missing for kepori)
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
necks clothing work, vox still work, humans/sorothy still work, i do not care about anything anymore, it has worked in game for the past like fucking 2 weeks minus the cloaks lets just fucking merge it, its been done for a while now, i will now fucking scream into the void
Honestly its better to get it merged anyways because we've been doing a lot of song and dance around it. Now everything can just be built on top of newkep. Thanks! |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> KEPORI.... TWO!! <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ![PEGGLETWO](https://github.com/shiptest-ss13/Shiptest/assets/81882910/834f7caa-909c-44fc-9da1-959af0df189c) ![image](https://github.com/shiptest-ss13/Shiptest/assets/81882910/20990212-0539-4812-985a-d000d83127af) This PR aims mostly for parity with existing Kepori customization. A few customization options were removed as they didn't offer much. Also adds a new "Head Feathers" sprite accessory type so it's not tied to body, as well as cleaning up existing sprite accessories. I believe this iteration of Kepori is closer to the original vision of what they should be, and was held back for various reasons during the past iteration. I've spent a long time on this, and I think it has come out very very well. Credits to `spookypineapple` for his great help during this process. This doesn't include everything for now. I cut out some old jumpsuits that needed updating as I'd have to fully resprite them anyways. Some of them don't even have resprited human versions, so whatever. TODO: Literally everything else (not in this PR) :cl: imageadd: Kepori have been given a full visual overhaul. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]> Co-authored-by: CoreyLee Hassell <[email protected]>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> KEPORI.... TWO!! <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ![PEGGLETWO](https://github.com/shiptest-ss13/Shiptest/assets/81882910/834f7caa-909c-44fc-9da1-959af0df189c) ![image](https://github.com/shiptest-ss13/Shiptest/assets/81882910/20990212-0539-4812-985a-d000d83127af) This PR aims mostly for parity with existing Kepori customization. A few customization options were removed as they didn't offer much. Also adds a new "Head Feathers" sprite accessory type so it's not tied to body, as well as cleaning up existing sprite accessories. I believe this iteration of Kepori is closer to the original vision of what they should be, and was held back for various reasons during the past iteration. I've spent a long time on this, and I think it has come out very very well. Credits to `spookypineapple` for his great help during this process. This doesn't include everything for now. I cut out some old jumpsuits that needed updating as I'd have to fully resprite them anyways. Some of them don't even have resprited human versions, so whatever. TODO: Literally everything else (not in this PR) :cl: imageadd: Kepori have been given a full visual overhaul. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: retlaw34 <[email protected]> Co-authored-by: CoreyLee Hassell <[email protected]>
About The Pull Request
KEPORI.... TWO!!
This PR aims mostly for parity with existing Kepori customization. A few customization options were removed as they didn't offer much. Also adds a new "Head Feathers" sprite accessory type so it's not tied to body, as well as cleaning up existing sprite accessories.
I believe this iteration of Kepori is closer to the original vision of what they should be, and was held back for various reasons during the past iteration. I've spent a long time on this, and I think it has come out very very well. Credits to
spookypineapple
for his great help during this process.This doesn't include everything for now. I cut out some old jumpsuits that needed updating as I'd have to fully resprite them anyways. Some of them don't even have resprited human versions, so whatever.
TODO:
Literally everything else (not in this PR)
Changelog
🆑
imageadd: Kepori have been given a full visual overhaul.
/:cl: