Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDB IGNORE]Kepori Visual Overhaul #2892

Merged
merged 19 commits into from
Jun 7, 2024
Merged

Conversation

thgvr
Copy link
Member

@thgvr thgvr commented Apr 12, 2024

About The Pull Request

KEPORI.... TWO!!

PEGGLETWO

image

This PR aims mostly for parity with existing Kepori customization. A few customization options were removed as they didn't offer much. Also adds a new "Head Feathers" sprite accessory type so it's not tied to body, as well as cleaning up existing sprite accessories.

I believe this iteration of Kepori is closer to the original vision of what they should be, and was held back for various reasons during the past iteration. I've spent a long time on this, and I think it has come out very very well. Credits to spookypineapple for his great help during this process.

This doesn't include everything for now. I cut out some old jumpsuits that needed updating as I'd have to fully resprite them anyways. Some of them don't even have resprited human versions, so whatever.

TODO:

Literally everything else (not in this PR)

Changelog

🆑
imageadd: Kepori have been given a full visual overhaul.
/:cl:

@thgvr thgvr requested a review from a team as a code owner April 12, 2024 10:38
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Apr 12, 2024
@Sun-Soaked
Copy link
Member

this will be breast in 2027

@Anticept
Copy link
Contributor

Anticept commented Apr 12, 2024

Wear that is not aligned that I have found so far:

  • Undergarments
  • Engineer scanning goggles (actually seems to be goggles in general)
  • Breath masks
  • boot blood

@Slim-Pickems
Copy link

FBP are, naturally, a bit bugged at the moment. I do assume this is already in the works, but are logging it for the sake of logging it.
scuffed

@thgvr
Copy link
Member Author

thgvr commented Apr 13, 2024

Take note of my TODOs in the pr body

@thgvr
Copy link
Member Author

thgvr commented Apr 13, 2024

Blood overlays I have no idea how to set up framework for new ones, gotta think about it

@Anticept
Copy link
Contributor

Anticept commented Apr 13, 2024

Something also keeps moving my sprite down and right from time to time.
image

Rotation, such as going horizontal or *flip, is rotating around the far left side of the sprite for some reason.

@thgvr thgvr marked this pull request as draft April 16, 2024 01:52
@Redrover1760
Copy link

Kepori cursed one
Welding goggles
^ Welding goggles floating

Anyways outside the memes I love the new sprites. Voxified Kepori? Yes please.

@thgvr
Copy link
Member Author

thgvr commented May 6, 2024

prosthetics are now "good enough"

@thgvr
Copy link
Member Author

thgvr commented May 6, 2024

Probably go for underwear parity then call this done

Copy link
Contributor

github-actions bot commented May 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 9, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label May 9, 2024
@thgvr thgvr marked this pull request as ready for review May 14, 2024 12:54
@thgvr
Copy link
Member Author

thgvr commented May 14, 2024

It's "done"

@Anticept
Copy link
Contributor

Character appearance is missing the Character Adjective when kepori species is selected. Changing to another species is a workaround to get it to show and change it.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 20, 2024
@thgvr thgvr marked this pull request as draft May 25, 2024 19:21
@Anticept
Copy link
Contributor

Anticept commented May 25, 2024

Looks like the red beret specifically is broken. I'm looking through the recent changes and I noticed some logic was inverted. If someone doesnt beat me to this, I might take a whack at it.
Tailbags were also broken.

It seems to be a lot more than the Red Beret, judging on previews in the character screen.

The reason I mentioned this is some hats do work, I just didn't have anything else to test with. So something weird is going on.

@rye-rice rye-rice changed the title Kepori Visual Overhaul [IDB IGNORE]Kepori Visual Overhaul May 27, 2024
@rye-rice
Copy link
Member

CHECK_USE_AUTOGEN, go fuck yourself

@rye-rice rye-rice marked this pull request as ready for review May 27, 2024 05:45
@Anticept
Copy link
Contributor

Anticept commented May 27, 2024

Ok so testing those latest changes, everything looks like its working properly wear wise (well, the stuff we have sprites for anyways. underwears don't work). I didnt do a 100% every single item test, but enough to touch on many that were having issues at one point or another.

There is one more thing: This is still missing:

Elzuose character screen:

image

Kepori screen:

image

I have no way of selecting the adj while kepori species is selected, though I can work around it by selecting another species then back to kepori again.

There's also other stuff that appears in that column that is inaccessible while kepori is selected as well (like phobia quirk)

EDIT: PR up for this PR to fix the missing preferences: thgvr#4

…how depending on species (ex phobias and character adjective missing for kepori)
@Anticept
Copy link
Contributor

Anticept commented May 27, 2024

Aside from the PR I linked in the previous post...

The entire /obj/item/clothing/neck/cloak typepath is not working. That includes SUNS cloaks, PGF cloaks, and NT command sashes.

image
image
image

/obj/item/clothing/neck/scarf paths ARE working however.

@FalloutFalcon FalloutFalcon added the Test Merged They've done it for free. label May 28, 2024
@thgvr thgvr marked this pull request as draft May 29, 2024 20:57
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Jun 7, 2024
@rye-rice rye-rice marked this pull request as ready for review June 7, 2024 20:47
Copy link
Member

@rye-rice rye-rice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

necks clothing work, vox still work, humans/sorothy still work, i do not care about anything anymore, it has worked in game for the past like fucking 2 weeks minus the cloaks lets just fucking merge it, its been done for a while now, i will now fucking scream into the void

@rye-rice rye-rice added this pull request to the merge queue Jun 7, 2024
Merged via the queue into shiptest-ss13:master with commit 3b4e076 Jun 7, 2024
14 checks passed
@Anticept
Copy link
Contributor

Anticept commented Jun 7, 2024

Honestly its better to get it merged anyways because we've been doing a lot of song and dance around it. Now everything can just be built on top of newkep. Thanks!

MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
KEPORI.... TWO!!
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

![PEGGLETWO](https://github.com/shiptest-ss13/Shiptest/assets/81882910/834f7caa-909c-44fc-9da1-959af0df189c)

![image](https://github.com/shiptest-ss13/Shiptest/assets/81882910/20990212-0539-4812-985a-d000d83127af)

This PR aims mostly for parity with existing Kepori customization. A few
customization options were removed as they didn't offer much. Also adds
a new "Head Feathers" sprite accessory type so it's not tied to body, as
well as cleaning up existing sprite accessories.

I believe this iteration of Kepori is closer to the original vision of
what they should be, and was held back for various reasons during the
past iteration. I've spent a long time on this, and I think it has come
out very very well. Credits to `spookypineapple` for his great help
during this process.

This doesn't include everything for now. I cut out some old jumpsuits
that needed updating as I'd have to fully resprite them anyways. Some of
them don't even have resprited human versions, so whatever.

TODO:

Literally everything else (not in this PR)

:cl:
imageadd: Kepori have been given a full visual overhaul.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: retlaw34 <[email protected]>
Co-authored-by: CoreyLee Hassell <[email protected]>
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Jun 22, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

KEPORI.... TWO!!
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

![PEGGLETWO](https://github.com/shiptest-ss13/Shiptest/assets/81882910/834f7caa-909c-44fc-9da1-959af0df189c)

![image](https://github.com/shiptest-ss13/Shiptest/assets/81882910/20990212-0539-4812-985a-d000d83127af)

This PR aims mostly for parity with existing Kepori customization. A few
customization options were removed as they didn't offer much. Also adds
a new "Head Feathers" sprite accessory type so it's not tied to body, as
well as cleaning up existing sprite accessories.

I believe this iteration of Kepori is closer to the original vision of
what they should be, and was held back for various reasons during the
past iteration. I've spent a long time on this, and I think it has come
out very very well. Credits to `spookypineapple` for his great help
during this process.

This doesn't include everything for now. I cut out some old jumpsuits
that needed updating as I'd have to fully resprite them anyways. Some of
them don't even have resprited human versions, so whatever.

TODO:

Literally everything else (not in this PR)

:cl:
imageadd: Kepori have been given a full visual overhaul.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: retlaw34 <[email protected]>
Co-authored-by: CoreyLee Hassell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes. Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants