-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes the nonfunctioning coffee machines #3015
Removes the nonfunctioning coffee machines #3015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wanted you could just remove the coffee machine but keep the syrup bottles, creamer, modify the coffee crate. I'm fine we removing them however.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to ihateyoucoffeeman
Forgot to mention in the PR that the syrup bottles are missing their base types. There is no empty syrup bottle object. I'd rather remove all of this to make room for someone to make a better port later on that actually functions. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Sun-Soaked <[email protected]>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> Undoes most of the changes from shiptest-ss13#2584 pertaining to coffee machines. The coffee machines didn't work, the coffee pot had missing sprites, and every sprite was shoved into the same dmi instead of being put into the proper files. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> Bad untested PR's go to Weewish. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> :cl: del: Removed nonfunctioning coffee machines and their cargo packs /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Sun-Soaked <[email protected]> Co-authored-by: Sun-Soaked <[email protected]>
About The Pull Request
Undoes most of the changes from #2584 pertaining to coffee machines. The coffee machines didn't work, the coffee pot had missing sprites, and every sprite was shoved into the same dmi instead of being put into the proper files.
Why It's Good For The Game
Bad untested PR's go to Weewish.
Changelog
🆑
del: Removed nonfunctioning coffee machines and their cargo packs
/:cl: