New Sandplanet Ruin: Cave Base #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
thgvr
previously requested changes
Sep 16, 2024
| @@ -20,3 +20,24 @@ | |||
| desc = "A .50 BMG penetrator bullet casing." | |||
| bullet_skin = "ap" | |||
| projectile_type = /obj/projectile/bullet/p50/penetrator | |||
|
|
|||
| //14.5mm Crunch Gun | |||
| /obj/item/ammo_casing/p145 | |||
There was a problem hiding this comment.
Yeah... this probably won't be happening
|
|
||
| //gut wrenching content | ||
|
|
||
| /datum/preset_holoimage/hapless_ipc |
|
|
||
|
|
||
| // x-com ufo defense high ex charge 1993 | ||
| /obj/item/grenade/c4/satchel_charge |
There was a problem hiding this comment.
This thing just feels a bit cheap to me. It pretty much only rewards knowing whats in the ruin beforehand, or having been there before.
There was a problem hiding this comment.
I'm not entirely sure how to rework it while still keeping the intent of it being a gotcha trap (that admittedly, won't trigger too often)
Erikafox
changed the title
Gristlebee
reviewed
Sep 30, 2024
There was a problem hiding this comment.
- Please add a picture of the ruin spawned in game.
- The turrets guarding the base are set to be non-lethal. Having them on lethal would add some bite. Some extra traps like mines could be a fitting addition as well for defences.
- The airlock controller detects the door to the generator/laundry room, which makes it not cycle properly.
- Items mapped on the same tile as a file cabinet get placed inside it on map gen. It isn't a big deal, but something to keep in mind if this wasn't intentional.
- The satchel charge is really strong, managing to fullgib me in an elite hardsuit. Getting rid of the devastation range should make it more manageable
- You've made a ruin with a strong story and premise, but my main concern when I look at this ruin is what there is not much to explore considering it's size. There is no compelling reason to check out the side caves, and the main content of the ruin, the base is on the small side. Some small rewards or greebles to reward looking around in the side caves would be a nice addition, along with some extra rooms in the base.
Gristlebee
reviewed
Oct 17, 2024
Gristlebee
dismissed
thgvr’s stale review
Outdated, issues have been addressed.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
fix checks ? |
…hiptest into sandplanet_crunch_gun
|
I love gambling |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
|
Aw dangit |
|
Let's go gambling! |
shiptest-server
pushed a commit
that referenced
this pull request
Oct 26, 2024
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds a new ruin to the sand planet ruin pool - a small installation built into a cave holding some explosive revelations. And a Big Gun. And satchel charges which are snowflaked c4. Also reformats blackboxes mildly so they can start empty.     <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game New map + simmy content <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Transceivers have been picking up an intermittent radio signal coming from a nearby sand world. People with too much spare time - please check it out. add: Satchel Charges. Exceedingly rare and decently explosive. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <[email protected]>
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Adds a new ruin to the sand planet ruin pool - a small installation built into a cave holding some explosive revelations. And a Big Gun. And satchel charges which are snowflaked c4. Also reformats blackboxes mildly so they can start empty.     <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game New map + simmy content <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: add: Transceivers have been picking up an intermittent radio signal coming from a nearby sand world. People with too much spare time - please check it out. add: Satchel Charges. Exceedingly rare and decently explosive. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Erika Fox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds a new ruin to the sand planet ruin pool - a small installation built into a cave holding some explosive revelations. And a Big Gun.
And satchel charges which are snowflaked c4.
Also reformats blackboxes mildly so they can start empty.
Why It's Good For The Game
New map + simmy content
Changelog
🆑
add: Transceivers have been picking up an intermittent radio signal coming from a nearby sand world. People with too much spare time - please check it out.
add: Satchel Charges. Exceedingly rare and decently explosive.
/:cl: