-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survey scanner #3373
Survey scanner #3373
Conversation
ok Co-authored-by: thgvr <[email protected]> Signed-off-by: Erika Fox <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really think the ore vein change is that great. We already greatly reduced the occurrence of ore veins in rock walls, as drill mining and defense is a more reliable method to acquire large amounts of ore.
For the survey scanner, at this point we've all but phased out RND equipment on ships in favor of cargo, so I unfortunately can't really see this serving much of a purpose as is.
I was thinking about making it equipment for a set of outpost missions, but that'd require some actual design discussion. |
else for(var/type in mob_mult_list) // THIS. ELSE IF(). ENDS. HERE. | ||
if(istype(target, type)) | ||
cost = (MAX_DISSECTION_REWARD*mob_mult_list[type]) | ||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replaced human dissections in #2722 and human/monkey dissection is uhh bad
Yeah this absolutely needs a design talk. Feel free to pull me into one but for now I'm gonna let this ferment in my collection of dead branches. |
About The Pull Request
Survey Scanners - Drafted.
Adds survey scanners to the game. Survey Scanners are a replacement system for the survey handheld. They require going outside (horrific) and engaging with the game to find survey points, which can then be scanned for research points. As a side result they adjust dissection values to make it less useful, and can also be used to discover ore veins (which now start semi-hidden, as they are underground)
I need to touch up the code before it's ready for a merge but they're perfectly functional right now
Changelog
🆑
add: Survey Scanners! A new-ish system for doing survey gameplay. That is to say there is actually gameplay now.
del: Survey handhelds
balance: Ore veins are now hidden until scanned properly.
/:cl: