Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey scanner #3373

Closed
wants to merge 62 commits into from
Closed

Survey scanner #3373

wants to merge 62 commits into from

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Sep 16, 2024

About The Pull Request

Survey Scanners - Drafted.

Adds survey scanners to the game. Survey Scanners are a replacement system for the survey handheld. They require going outside (horrific) and engaging with the game to find survey points, which can then be scanned for research points. As a side result they adjust dissection values to make it less useful, and can also be used to discover ore veins (which now start semi-hidden, as they are underground)

I need to touch up the code before it's ready for a merge but they're perfectly functional right now

  • have a design discussion to see if these should be used
  • if the answer is yes redesign and implement.

Changelog

🆑
add: Survey Scanners! A new-ish system for doing survey gameplay. That is to say there is actually gameplay now.
del: Survey handhelds
balance: Ore veins are now hidden until scanned properly.
/:cl:

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 16, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Sep 16, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 16, 2024
Copy link
Member

@thgvr thgvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really think the ore vein change is that great. We already greatly reduced the occurrence of ore veins in rock walls, as drill mining and defense is a more reliable method to acquire large amounts of ore.

For the survey scanner, at this point we've all but phased out RND equipment on ships in favor of cargo, so I unfortunately can't really see this serving much of a purpose as is.

@Erikafox
Copy link
Contributor Author

I was thinking about making it equipment for a set of outpost missions, but that'd require some actual design discussion.

Comment on lines -75 to -78
else for(var/type in mob_mult_list) // THIS. ELSE IF(). ENDS. HERE.
if(istype(target, type))
cost = (MAX_DISSECTION_REWARD*mob_mult_list[type])
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaced human dissections in #2722 and human/monkey dissection is uhh bad

@Erikafox
Copy link
Contributor Author

Yeah this absolutely needs a design talk. Feel free to pull me into one but for now I'm gonna let this ferment in my collection of dead branches.

@Erikafox Erikafox closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants