Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit existing documentation #1042

Closed
qu1queee opened this issue Apr 20, 2022 · 3 comments · Fixed by #1632
Closed

Revisit existing documentation #1042

qu1queee opened this issue Apr 20, 2022 · 3 comments · Fixed by #1632
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@qu1queee
Copy link
Contributor

Per Grooming, we want to revisit the current docs in this repo. We are looking for:

  • typos
  • markdown linters warnings
  • broken links

Aim is to keep our docs optimal, as they will serve as the source of truth for our website.

@qu1queee qu1queee added this to the release-v0.10.0 milestone Apr 20, 2022
@qu1queee qu1queee added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 20, 2022
@avinal
Copy link
Contributor

avinal commented Jun 11, 2024

Hey @SaschaSchwarze0 I want to work on this issue. I have one suggestion on the line length, it is default at 80 chars using any markdownlint, for better readability, I propose to use either 100 or 120 chars. I will start working once we agree on this.

@SaschaSchwarze0
Copy link
Member

Hey @SaschaSchwarze0 I want to work on this issue. I have one suggestion on the line length, it is default at 80 chars using any markdownlint, for better readability, I propose to use either 100 or 120 chars. I will start working once we agree on this.

Thanks @avinal for volunteering. Do we really have a line length limit in a markdown linter somewhere? I know them for code files, but for markdown? I am against any line limit in markdown as I prefer a paragraph to be a single line - editors like vscode can then dynamically line-break based on the window size.

We actually have long lines like https://github.com/shipwright-io/build/blob/main/docs/build.md?plain=1#L56C126-L57C1. I am using https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint as linter and that file is validated without any warnings.

@avinal
Copy link
Contributor

avinal commented Jun 21, 2024

There is no hard rule and yes, modern editors automatically wrap long lines. I will then ignore the line length limitation and fix the other linting issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants