Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example conversion of Shipwright docs to Asciidoc #1110

Closed
wants to merge 1 commit into from

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Sep 5, 2022

Changes

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

none

@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Sep 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign saschaschwarze0 for approval by writing /assign @saschaschwarze0 in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rolfedh
Copy link
Contributor Author

rolfedh commented Sep 6, 2022

/release-note-none

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

@rolfedh: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rolfedh
Copy link
Contributor Author

rolfedh commented Sep 6, 2022

/kind docs

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

@rolfedh: The label(s) kind/docs cannot be applied, because the repository doesn't have them.

In response to this:

/kind docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note and removed release-note Label for when a PR has specified a release note labels Sep 6, 2022
@rolfedh
Copy link
Contributor Author

rolfedh commented Sep 6, 2022

/release-note-none

@rolfedh
Copy link
Contributor Author

rolfedh commented Sep 6, 2022

/kind docs
/kind documentation

@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

@rolfedh: The label(s) kind/docs cannot be applied, because the repository doesn't have them.

In response to this:

/kind docs
/kind documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coreydaley
Copy link
Contributor

/close
Superseded by #1334

@openshift-ci openshift-ci bot closed this Aug 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

@coreydaley: Closed this PR.

In response to this:

/close
Superseded by #1334

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. release-note-none Label for when a PR does not need a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants