Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BETA API] With the v1beta1 changes introduced, need to determine the scope for test changes required #1373

Closed
1 task done
apoorvajagtap opened this issue Sep 4, 2023 · 3 comments · Fixed by #1388
Closed
1 task done
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@apoorvajagtap
Copy link
Member

apoorvajagtap commented Sep 4, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Anything else?

As #1352 introduces changes to samples of all the CRs, which might affect the existing e2e test cases. Raising this issue to discuss the scope of test cases that need immediate attention.

@apoorvajagtap apoorvajagtap added the kind/bug Categorizes issue or PR as related to a bug. label Sep 4, 2023
@qu1queee qu1queee added this to the release-v0.12.0 milestone Sep 6, 2023
@qu1queee qu1queee added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed kind/bug Categorizes issue or PR as related to a bug. labels Sep 6, 2023
@apoorvajagtap
Copy link
Member Author

apoorvajagtap commented Sep 11, 2023

@qu1queee @SaschaSchwarze0 I can observe that we have few YAML examples in test/data, which are being used within the test suites. Should these be updated as per v1beta1?

@SaschaSchwarze0
Copy link
Member

@qu1queee @SaschaSchwarze0 I can observe that we have few YAML examples in test/data, which are being used within the test suites. Should these be updated as per v1beta1?

It would make sense to not migrate everything to Beta in test/data but to retain some Alpha objects to keep them covered (especially relevant when alpha eventually is not anymore the stored version).

@qu1queee
Copy link
Contributor

From refinement, @apoorvajagtap to introduce some changes related to duplicate e2e tests. We will sync on this topic after that. Per the discussion, we do not have clarity on the best approach for e2e tests. The options are:

  • move e2e to v1beta1, consequence is that we lose testing for alpha once the storage version becomes beta(v0.13.0 release)
  • introduce e2e tests for both versions.

@qu1queee qu1queee moved this to In Progress in Shipwright Overview Sep 20, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Shipwright Overview Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants