Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit empty output object in BuildRun spec #1410

Conversation

SaschaSchwarze0
Copy link
Member

Changes

When a BuildRun without an output is converted to Beta, then this looks like this:

apiVersion: shipwright.io/v1beta1
kind: BuildRun
spec:
  build:
    name: build-name
  output:
    image: ""
  serviceAccount: sa-name

The empty output section is not desired, especially as it has a mandatory image field which is then rendered as an empty string.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 18, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Oct 18, 2023
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Oct 18, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2023
@openshift-ci openshift-ci bot requested a review from otaviof October 18, 2023 20:23
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-fix-buildrun-spec-output branch from f5ef32c to c2f155d Compare October 19, 2023 06:08
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@openshift-ci openshift-ci bot merged commit afb4bdc into shipwright-io:main Oct 19, 2023
11 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-fix-buildrun-spec-output branch August 7, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants