Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve on buildCredentialserences function name #1501

Closed
1 task done
qu1queee opened this issue Feb 20, 2024 · 2 comments · Fixed by #1506
Closed
1 task done

[FEATURE] Improve on buildCredentialserences function name #1501

qu1queee opened this issue Feb 20, 2024 · 2 comments · Fixed by #1506
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

this function https://github.com/shipwright-io/build/blob/main/pkg/validate/secrets.go#L61 is misleading and uses a name grammatically incorrect.

Describe the solution that you would like.

Fix the function name

Describe alternatives you have considered.

No response

Anything else?

No

@qu1queee qu1queee added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 20, 2024
@qu1queee qu1queee added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 22, 2024
@SaschaSchwarze0
Copy link
Member

/assign Adarsh-jaiss

Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@SaschaSchwarze0: GitHub didn't allow me to assign the following users: Adarsh-jaiss.

Note that only shipwright-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign Adarsh-jaiss

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants