Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move Readme Try It Section to BETA #1502

Closed
1 task done
qu1queee opened this issue Feb 20, 2024 · 5 comments · Fixed by #1535
Closed
1 task done

[FEATURE] Move Readme Try It Section to BETA #1502

qu1queee opened this issue Feb 20, 2024 · 5 comments · Fixed by #1535
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

Move readme contents to BETA

Describe the solution that you would like.

BETA API in use in the README

Describe alternatives you have considered.

None

Anything else?

Must be done after the code is moved to BETA

@qu1queee qu1queee added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 20, 2024
@qu1queee qu1queee added this to the release-v0.13.0 milestone Feb 22, 2024
@qu1queee qu1queee added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Feb 22, 2024
@Adarsh-jaiss
Copy link
Member

Hey @qu1queee, can you please describe about the issue, where do i need to move the "Try it" section as i was looking for the BETA section/file in the whole codebase, but did'nt found it!

@qu1queee
Copy link
Contributor Author

qu1queee commented Mar 4, 2024

@Adarsh-jaiss thanks for your interest. It's about this line https://github.com/shipwright-io/build/blob/main/README.md?plain=1#L91, we need to use a different API version, and therefore change the structure of the Build and BuildRun objects in the description of the Try It! section. I can do this as well, or we can have a pairing session.

@Adarsh-jaiss
Copy link
Member

fferent AP

Hey, @qu1queee , I would love to assist you. Let's have a pairing session at your time :)

@qu1queee
Copy link
Contributor Author

qu1queee commented Mar 6, 2024

@Adarsh-jaiss can u ping me in Slack, we have a Shipwright dedicated channel, it easier if we connect there.

@Adarsh-jaiss
Copy link
Member

Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants