Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed buildCredentialserences function name #1506

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fixed buildCredentialserences function name #1506

merged 1 commit into from
Feb 27, 2024

Conversation

Adarsh-jaiss
Copy link
Member

@Adarsh-jaiss Adarsh-jaiss commented Feb 27, 2024

Description:

This Pull Request Fixes #1501 by improving the naming of the buildCredentialserences function in secrets.go. The current function name is misleading and grammatically incorrect. The function has been renamed to buildCredentialReferences to better reflect its purpose and adhere to proper naming conventions.

Changes

  • Renamed the function buildCredentialserences to buildCredentialReferences in secrets.go.
  • Updated all references to the function throughout the codebase to use the new name.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 27, 2024
@SaschaSchwarze0
Copy link
Member

@Adarsh-jaiss thank you for the PR. May you adjust the PR description to use the PR template. We have validation that especially looks for the release notes section which for this case should be set to NONE, though it still is expected to be present.

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Feb 27, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@Adarsh-jaiss
Copy link
Member Author

@Adarsh-jaiss thank you for the PR. May you adjust the PR description to use the PR template. We have validation that especially looks for the release notes section which for this case should be set to NONE, though it still is expected to be present.

Thank you so much for sir for the Approval
I'll just fix it :)

@openshift-ci openshift-ci bot added release-note Label for when a PR has specified a release note release-note-none Label for when a PR does not need a release note and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Label for when a PR has specified a release note labels Feb 27, 2024
@SaschaSchwarze0
Copy link
Member

@Adarsh-jaiss thank you for the PR. May you adjust the PR description to use the PR template. We have validation that especially looks for the release notes section which for this case should be set to NONE, though it still is expected to be present.

Thank you so much for sir for the Approval I'll just fix it :)

I edited it for you. ;-)

@openshift-merge-bot openshift-merge-bot bot merged commit c2f2881 into shipwright-io:main Feb 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve on buildCredentialserences function name
2 participants