-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed buildCredentialserences function name #1506
Fixed buildCredentialserences function name #1506
Conversation
@Adarsh-jaiss thank you for the PR. May you adjust the PR description to use the PR template. We have validation that especially looks for the release notes section which for this case should be set to NONE, though it still is expected to be present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you so much for sir for the Approval |
I edited it for you. ;-) |
Description:
This Pull Request Fixes #1501 by improving the naming of the buildCredentialserences function in secrets.go. The current function name is misleading and grammatically incorrect. The function has been renamed to buildCredentialReferences to better reflect its purpose and adhere to proper naming conventions.
Changes
Release Notes