Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubernetes / controller-runtime / controller-gen / Tekton dependencies #1513

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Mar 1, 2024

Changes

  • Update Kubernetes in go.mod to v0.27.11
  • Update controller-runtime in go.mod to v0.15.3, plus a few necessary code updates
  • Update Tekton in go.mod to v0.50.5
  • Update e2e/integration to test k8s 1.27.11 and 1.29.2 with Tekton v0.50.5
  • Update support statement for Kubernetes and Tekton
  • Remove usage of deprecated wait.PollImmediate() function to make golangci-lint happy

Fixes #1505

The PR changes the checks due to the changed Kubernetes versions. We will need to red-merge this and adjust checks afterwards.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The minimum Kubernetes version is now 1.27. The minimum Tekton version is 0.50.

@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Mar 1, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Mar 1, 2024
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Mar 1, 2024
@openshift-ci openshift-ci bot requested review from HeavyWombat and qu1queee March 1, 2024 15:32
@SaschaSchwarze0 SaschaSchwarze0 changed the title Update Kubernetes / controller-ge / Tekton dependencies Update Kubernetes / controller-runtime / controller-gen / Tekton dependencies Mar 1, 2024
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, thanks.

/approve

Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
Update controller-runtime in go.mod to v0.15.3, plus a few necessary code updates
Update Tekton in go.mod to v0.50.5
Update e2e/integration to test k8s 1.27.11 and 1.29.2 with Tekton v0.50.5
Update support statement for Kubernetes and Tekton
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-update-dependencies branch from 4cfa6c5 to 2bc6ffc Compare March 4, 2024 20:17
@SaschaSchwarze0
Copy link
Member Author

Rebased to resolve conflicts.

Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2c208d4 into shipwright-io:main Mar 5, 2024
12 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-update-dependencies branch August 7, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEATURE] v0.13 Bump Tekton and Kubernetes dependencies
3 participants