-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump peter-evans/create-pull-request from 3.10.0 to 6.0.1 #1525
Bump peter-evans/create-pull-request from 3.10.0 to 6.0.1 #1525
Conversation
@SaschaSchwarze0 @qu1queee Not sure about this one. I would actually say we should switch from the digest to a version number in the PR job to be consistent with other usage. Also, since it is bumping the major version, we need to check https://github.com/peter-evans/create-pull-request/releases first. Thoughts? |
Yeah, so, on this one I was not approving right away. Reason: all other actions (checkout, setup-go, setup-ko, etc) run as part of the PR actions. We therefore validated that they are still functional in the way we are using them with the new version. For this one, that is not the case. I assume it is used as part of the build strategy bump and/or the release logic where we PR an update to the readme to include the new tag. So yes, we need to be more careful in reading release notes. |
@HeavyWombat can you pls do the enhancement, from the digest to the version in .github/workflows/release.yaml ? |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 3.10.0 to 6.0.1. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v3.10.0...v6.0.1) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Use version tag `v6.0.1` instead of image has to be consistent with other use. Signed-off-by: Matthias Diester <[email protected]>
7b042f9
to
8f5a858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A newer version of peter-evans/create-pull-request exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
I needed to update the description for the release note linter to work, because it looks like the edit of the commits led to the author check in the Action to not register this as a Dependabot PR anymore. |
@dependabot recreate |
Looks like peter-evans/create-pull-request is up-to-date now, so this is no longer needed. |
Changes
Bumps peter-evans/create-pull-request from 3.10.0 to 6.0.1.
Release notes
Sourced from peter-evans/create-pull-request's releases.
... (truncated)
Commits
a4f52f8
fix: list pulls using the correct head format (#2792)853c071
build(deps-dev): bump eslint from 8.56.0 to 8.57.0 (#2781)d2c126e
build(deps-dev): bump@types/node
from 18.19.17 to 18.19.18 (#2780)43d39c6
build(deps-dev): bump@types/node
from 18.19.15 to 18.19.17 (#2768)5a9d206
build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.9.0 (#2769)e0743ed
build(deps-dev): bump@types/node
from 18.19.14 to 18.19.15 (#2759)e1529cb
build(deps): bump peter-evans/create-pull-request from 5 to 6 (#2747)aad52e8
build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 (#2748)a64ebdd
build(deps-dev): bump@types/node
from 18.19.10 to 18.19.14 (#2732)51b40af
build(deps-dev): bump prettier from 3.2.4 to 3.2.5 (#2731)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes