Improve conversion webhook logging #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure Info log is kept to a minimal Ensure log content is valuable: - provide conversion request UID - provide conversion response UID and status
qu1queee
added
the
kind/cleanup
pull-request-size
bot
added
the
size/S
openshift-ci
bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensure Info log is kept to a minimal
Ensure log content is valuable:
Upon conversion of an object, this is how the webhook will log:
{"level":"debug","ts":"2024-03-20T12:31:01Z","logger":"shp-build-webhook","msg":"handling request"} {"level":"info","ts":"2024-03-20T12:31:01Z","logger":"shp-build-webhook","msg":"conversion request","uid":"0fea4dac-0a67-4c2f-b01c-4798ae7de382"} {"level":"debug","ts":"2024-03-20T12:31:01Z","logger":"shp-build-webhook","msg":"converting custom resource"} {"level":"info","ts":"2024-03-20T12:31:01Z","logger":"shp-build-webhook","msg":"converting Build from beta to alpha","namespace":"default","name":"buildkit-build"} {"level":"info","ts":"2024-03-20T12:31:01Z","logger":"shp-build-webhook","msg":"conversion response","status":"Success","uid":"0fea4dac-0a67-4c2f-b01c-4798ae7de382"}Submitter Checklist
Release Notes