Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provide Storage Version Migration from v1alpha1 to v1beta1 #1603

Closed
1 task done
SaschaSchwarze0 opened this issue May 16, 2024 · 1 comment · Fixed by #1646
Closed
1 task done

[FEATURE] Provide Storage Version Migration from v1alpha1 to v1beta1 #1603

SaschaSchwarze0 opened this issue May 16, 2024 · 1 comment · Fixed by #1646
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@SaschaSchwarze0
Copy link
Member

Is there an existing feature request for this?

  • I have searched the existing feature requests

Is your feature request related to a problem or use-case? Please describe.

With v0.13 we changed the storage version of Shipwright Build from v1alpha1 to v1beta1. Users who started with an older version will find the following in the the CRD status:

status:
  storedVersions:
  - v1alpha1
  - v1beta1

As long as v1alpha1 is in there, it is not possible to apply a CRD where v1alpha1 does not exist anymore.

Describe the solution that you would like.

Kubernetes v1.30 actually brought storage version migration: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/storage-version-migration/ (I never tried it)

For users of older version we need to provide a Job definition similar to what Knative does: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/storage-version-migration/.

We can even use their image because its code is generic. If we prefer we could also copy the code. Code is here: https://github.com/knative/pkg/tree/main/apiextensions/storageversion

Describe alternatives you have considered.

We could also make that part of our controller startup, would be maybe an alterantive where our users must not care at all.

Anything else?

No response

@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label May 16, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone May 16, 2024
@karanibm6
Copy link
Contributor

/assign @karanibm6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants