Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove that kaniko-trivy build strategy sample #1629

Conversation

SaschaSchwarze0
Copy link
Member

Changes

As decided in the community meeting, I am removing the kaniko-trivy sample build strategy given vulnerability scanning is now a first class capability in this component.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The kaniko-trivy sample build strategy is removed as you can now enable a vulnerability scan for the image in the output section of your Build or BuildRun

@SaschaSchwarze0 SaschaSchwarze0 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 21, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Jun 21, 2024
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jun 21, 2024
@openshift-ci openshift-ci bot requested review from apoorvajagtap and qu1queee June 21, 2024 19:16
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 21, 2024
Copy link
Contributor

@karanibm6 karanibm6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@qu1queee qu1queee removed the request for review from apoorvajagtap June 26, 2024 06:39
@qu1queee
Copy link
Contributor

/approved

@qu1queee qu1queee added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: karanibm6

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 873b941 into shipwright-io:main Jun 27, 2024
13 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-remove-kaniko-trivy branch August 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants