Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct regex that selects the lines with image changes #1746

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Correct regex that selects the lines with image changes #1746

merged 1 commit into from
Dec 10, 2024

Conversation

SaschaSchwarze0
Copy link
Member

Changes

PR #1745 is opened without version information in the title because the regular expression only selected git diff lines with image names with at least two / characters, but moby/buildkit has only one. Using just .* is good enough there because it selects the full image name.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Dec 9, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Dec 9, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Dec 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2024
HeavyWombat
HeavyWombat approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ef44dca into shipwright-io:main Dec 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeavyWombat HeavyWombat HeavyWombat approved these changes

@karanibm6 karanibm6 Awaiting requested review from karanibm6

Assignees

@HeavyWombat HeavyWombat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SaschaSchwarze0 @HeavyWombat