Simplify GitSource proxy settings #682
Labels
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
priority/awaiting-more-evidence
Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Milestone
The GitSource type has a few fields related to proxying requests:
(ref)
Would it make sense to communicate this information in one field,
Proxy string
json:"proxy"`?At the time people are defining the source, they would know whether it's an HTTP or HTTPS repo, and I don't know why they'd want to specify "don't proxy this domain" -- is that the default?
These were added long long ago, alongside a lot of other stuff, so I don't know if they were added with a particular purpose in mind. @sbose78 might know.
With a single
Proxy
field, we could generateHTTPS_PROXY=${proxy} HTTP_PROXY=${proxy} git clone ${url}
if it's set, and justgit clone ${url}
otherwise, unless there's some semantics to Git proxying I'm not understanding (entirely possible!)(This isn't a high priority but it might make sense to try to do this before v1beta1 and definitely before v1)
The text was updated successfully, but these errors were encountered: