Provide a container image with development tools

[akram]

Changes

NONE

Fixes #586
Fixes #832

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

[akram]

it is also a workaround for #832 , so let's say: fixes #832 temporarly

[gabemontero]

it is also a workaround for #832 , so let's say: fixes #832 temporarly

I think we should say it "officially" fixes it .... let's not gate our issue on when they get a new version of controller-gen out with your upstream fix @akram

[gabemontero]

it is also a workaround for #832 , so let's say: fixes #832 temporarly

I think we should say it "officially" fixes it .... let's not gate our issue on when they get a new version of controller-gen out with your upstream fix @akram

pending the hiccup I'm seeing that we are discussing in slack :-)

[akram]

/retest

[openshift-ci]

@akram: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[akram]

/assign @otaviof @gabemontero

[SaschaSchwarze0]

This will be a nice tool, thank you. Suggesting a "little" relocation.

[SaschaSchwarze0]

This file should not be such prominent in the root directory of the project, I think, people might think that this builds the project output. Here is my proposal:

• move it to a sub-directory inside https://github.com/shipwright-io/build/tree/main/images
• we can build the image nightly, for example in https://github.com/shipwright-io/build/blob/main/.github/workflows/base-images.yaml, the file name is a bit mis-leading (could be images.yaml instead), I think you can even let it build multi-platform like we do for the git base image

Subsequently, we don't need make container-image and make container-make can use the image from our shipwright-org.

[akram]

got it @SaschaSchwarze0 except the last point

Subsequently, we don't need make container-image and make container-make can use the image from our shipwright-org.

[gabemontero]

/kind dependency-change

[gabemontero]

/approve

will let @SaschaSchwarze0 @otaviof do the LGTM once their requests have been addressed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adambkaplan]

@akram bump on this pull request. Are you still working on this?

[akram]

@adambkaplan : I just updated it. For sure, that's helpful for the hackaton

[SaschaSchwarze0]

You'll have to make changes to the images.yaml to build the image.

[SaschaSchwarze0]

Hi @akram, in response to #873 (comment).

[SaschaSchwarze0]

Imo overcomplicated wrt the amount of variables used here.

Suggested change

	# The CONTAINER_ENGINE variable is used for specifying the container engine. By default 'docker' is used
	# # but this can be overridden when calling make, e.g.
	# # CONTAINER_ENGINE=podman make container-image
	CONTAINER_ENGINE ?= docker
	IMAGE_REGISTRY ?= ghcr.io/shipwright-io
	SHIPWRIGHT_VERSION = latest
	DEVELOPER_TOOLS_DOCKERFILE = images/developer-tools/Dockerfile
	IMAGE_VERSION = $(shell scripts/hash-files.sh $(DEVELOPER_TOOLS_DOCKERFILE) Makefile | cut -c 1-12)
	CONTAINER_IMAGE = $(IMAGE_REGISTRY)/shipwright-builder-image:$(SHIPWRIGHT_VERSION)-$(IMAGE_VERSION)
	CONTAINER_RUN = $(CONTAINER_ENGINE) run --rm --interactive --tty --volume $(CURDIR):/src
	# The CONTAINER_ENGINE variable is used for specifying the container engine. By default 'docker' is used
	# # but this can be overridden when calling make, e.g.
	# # CONTAINER_ENGINE=podman make container-make
	CONTAINER_ENGINE ?= docker
	BUILDER_IMAGE ?= ghcr.io/shipwright-io/shipwright-builder-image:latest

[SaschaSchwarze0]

I'd remove this because the image is built by the GitHub action and can be consumed instead of everybody being required to build it locally. The only use other use case would be to locally build it for developer purposes. If we really think that we need a make target for this, then I'd rename the target to build-shipwright-builder-image.

[SaschaSchwarze0]

Let's use the public one.

Suggested change

	container-make: container-image ## Run make using the development container. A target can be passed using the TARGET=my-target argument. Example: `make container-make TARGET=ginkgo` Run `make container-image` before this.
	$(CONTAINER_RUN) --cap-drop=ALL --cap-add=AUDIT_WRITE --mount type=tmpfs,destination=/tmp,tmpfs-mode=01777 $(CONTAINER_IMAGE) make $(TARGET)
	container-make: ## Run make using the development container. A target can be passed using the TARGET=my-target argument. Example: `make container-make TARGET=ginkgo`
	$(CONTAINER_ENGINE) run --rm --interactive --tty --volume $(CURDIR):/src --cap-drop=ALL --cap-add=AUDIT_WRITE --mount type=tmpfs,destination=/tmp,tmpfs-mode=01777 $(BUILDER_IMAGE) make $(TARGET)

[openshift-ci]

@akram: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adambkaplan]

/lifecycle stale

[qu1queee]

Closing per the stale status, please feel free to reopen.