From 9bf65ca7234f43f8b18844add53312c5fcd9e1b6 Mon Sep 17 00:00:00 2001 From: encalada Date: Tue, 13 Feb 2024 09:56:56 +0100 Subject: [PATCH] Fix golangci-lint findings Rename unused parameter --- pkg/reconciler/build/controller.go | 2 +- pkg/reconciler/buildlimitcleanup/controller.go | 6 +++--- pkg/reconciler/buildrun/controller.go | 2 +- pkg/reconciler/buildrunttlcleanup/controller.go | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/reconciler/build/controller.go b/pkg/reconciler/build/controller.go index a600894707..ec46c7500b 100644 --- a/pkg/reconciler/build/controller.go +++ b/pkg/reconciler/build/controller.go @@ -84,7 +84,7 @@ func add(ctx context.Context, mgr manager.Manager, r reconcile.Reconciler, maxCo // or BuildRunDeletion annotation does not change return o.GetGeneration() != n.GetGeneration() || buildRunDeletionAnnotation }, - DeleteFunc: func(e event.DeleteEvent) bool { + DeleteFunc: func(_ event.DeleteEvent) bool { // Never reconcile on deletion, there is nothing we have to do return false }, diff --git a/pkg/reconciler/buildlimitcleanup/controller.go b/pkg/reconciler/buildlimitcleanup/controller.go index adedbbe8bb..15bd8240e4 100644 --- a/pkg/reconciler/buildlimitcleanup/controller.go +++ b/pkg/reconciler/buildlimitcleanup/controller.go @@ -75,14 +75,14 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in } return false }, - DeleteFunc: func(e event.DeleteEvent) bool { + DeleteFunc: func(_ event.DeleteEvent) bool { // Never reconcile on deletion, there is nothing we have to do return false }, } predBuildRun := predicate.Funcs{ - CreateFunc: func(e event.CreateEvent) bool { + CreateFunc: func(_ event.CreateEvent) bool { // Never reconcile in case of create buildrun event return false }, @@ -106,7 +106,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in } return false }, - DeleteFunc: func(e event.DeleteEvent) bool { + DeleteFunc: func(_ event.DeleteEvent) bool { // Never reconcile on deletion, there is nothing we have to do return false }, diff --git a/pkg/reconciler/buildrun/controller.go b/pkg/reconciler/buildrun/controller.go index 034c19906b..d241ada9a4 100644 --- a/pkg/reconciler/buildrun/controller.go +++ b/pkg/reconciler/buildrun/controller.go @@ -73,7 +73,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in return false }, - DeleteFunc: func(e event.DeleteEvent) bool { + DeleteFunc: func(_ event.DeleteEvent) bool { // Never reconcile on deletion, there is nothing we have to do return false }, diff --git a/pkg/reconciler/buildrunttlcleanup/controller.go b/pkg/reconciler/buildrunttlcleanup/controller.go index 6d997aad1b..fe893363bc 100644 --- a/pkg/reconciler/buildrunttlcleanup/controller.go +++ b/pkg/reconciler/buildrunttlcleanup/controller.go @@ -131,7 +131,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler, maxConcurrentReconciles in return false }, - DeleteFunc: func(e event.DeleteEvent) bool { + DeleteFunc: func(_ event.DeleteEvent) bool { // Never reconcile on deletion, there is nothing we have to do return false },